Sign upLogin

atlassian/localstack

View on GitHub
Star
localstack/services/dynamodb/dynamodb_listener.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function update_dynamodb has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

def update_dynamodb(method, path, data, headers, response=None, return_forward_info=False):
    if return_forward_info:
        if random.random() < config.DYNAMODB_ERROR_PROBABILITY:
            return dynamodb_error_response(data)
        return True
Severity: Minor
Found in localstack/services/dynamodb/dynamodb_listener.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_dynamodb has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def update_dynamodb(method, path, data, headers, response=None, return_forward_info=False):
Severity: Minor
Found in localstack/services/dynamodb/dynamodb_listener.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

            return
    Severity: Major
    Found in localstack/services/dynamodb/dynamodb_listener.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return
      Severity: Major
      Found in localstack/services/dynamodb/dynamodb_listener.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status