Sign upLogin

atsid/generator-ats-node-webapp

View on GitHub
Star

Showing 61 of 61 total issues

Function packageJson has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  packageJson() {
    this.addDependencies(
      'body-parser',
      'compression',
      'cookie-parser',
Severity: Minor
Found in generators/server-full/phases/writing.js - About 1 hr to fix

Function process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  process(dir, templateDir, context) {
    fs.readdirSync(dir).forEach((file) => {
      const filePath = path.join(dir, file);
      const templatePath = path.join(templateDir, file);
      const isDirectory = fs.statSync(filePath).isDirectory();
Severity: Minor
Found in util/writer.js - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

module.exports = (profile) => {
  return {
    googleId: '' + profile.id,
    name: profile.displayName,
    password: hat(),
Severity: Major
Found in generators/auth-google/templates/server/initialization/sections/passport/strategies/google/convert_google_profile.js and 3 other locations - About 55 mins to fix
generators/auth-github/templates/server/initialization/sections/passport/strategies/github/convert_github_profile.js on lines 8..14
generators/auth-linkedin/templates/server/initialization/sections/passport/strategies/linkedin/convert_linkedin_profile.js on lines 8..14
generators/auth-twitter/templates/server/initialization/sections/passport/strategies/twitter/convert_twitter_profile.js on lines 8..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

module.exports = (profile) => {
  return {
    twitterId: '' + profile.id,
    name: profile.name,
    password: hat(),
Severity: Major
Found in generators/auth-twitter/templates/server/initialization/sections/passport/strategies/twitter/convert_twitter_profile.js and 3 other locations - About 55 mins to fix
generators/auth-github/templates/server/initialization/sections/passport/strategies/github/convert_github_profile.js on lines 8..14
generators/auth-google/templates/server/initialization/sections/passport/strategies/google/convert_google_profile.js on lines 8..14
generators/auth-linkedin/templates/server/initialization/sections/passport/strategies/linkedin/convert_linkedin_profile.js on lines 8..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

module.exports = (profile) => {
  return {
    linkedinId: '' + profile.id,
    name: profile.displayName,
    password: hat(),
Severity: Major
Found in generators/auth-linkedin/templates/server/initialization/sections/passport/strategies/linkedin/convert_linkedin_profile.js and 3 other locations - About 55 mins to fix
generators/auth-github/templates/server/initialization/sections/passport/strategies/github/convert_github_profile.js on lines 8..14
generators/auth-google/templates/server/initialization/sections/passport/strategies/google/convert_google_profile.js on lines 8..14
generators/auth-twitter/templates/server/initialization/sections/passport/strategies/twitter/convert_twitter_profile.js on lines 8..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

module.exports = (profile) => {
  return {
    githubId: '' + profile.id,
    name: profile.displayName,
    password: hat(),
Severity: Major
Found in generators/auth-github/templates/server/initialization/sections/passport/strategies/github/convert_github_profile.js and 3 other locations - About 55 mins to fix
generators/auth-google/templates/server/initialization/sections/passport/strategies/google/convert_google_profile.js on lines 8..14
generators/auth-linkedin/templates/server/initialization/sections/passport/strategies/linkedin/convert_linkedin_profile.js on lines 8..14
generators/auth-twitter/templates/server/initialization/sections/passport/strategies/twitter/convert_twitter_profile.js on lines 8..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      gulp.src(TEST_CODE)
        .pipe(doDebug('test'))
        .pipe(mocha())
        .pipe(istanbul.writeReports())
        .on('end', cb);
Severity: Minor
Found in gulpfile.js and 1 other location - About 50 mins to fix
gulpfile.js on lines 47..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return gulp.src(GENERATOR_CODE)
    .pipe(doDebug('lint'))
    .pipe(eslint())
    .pipe(eslint.format())
    .pipe(eslint.failAfterError());
Severity: Minor
Found in gulpfile.js and 1 other location - About 50 mins to fix
gulpfile.js on lines 38..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function runTests has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function runTests(sourceGlob, testGlob, reportDir, reporter = DEFAULT_SPEC_REPORTER, coverageReporters = DEFAULT_COVERAGE_REPORTERS, tdd = false) {
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/test.js - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  create(data) {
    return new Promise((resolve, reject) => {
      this._models.User.create(data, autohandle(resolve, reject));
    });
  }
Severity: Minor
Found in generators/persistence-mongodb/templates/server/persistence/repositories/Users.js and 1 other location - About 40 mins to fix
generators/persistence-mongodb/templates/server/persistence/repositories/Users.js on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  findOneByCriteria(criteria) {
    return new Promise((resolve, reject) => {
      this._models.User.findOne(criteria, autohandle(resolve, reject));
    });
  }
Severity: Minor
Found in generators/persistence-mongodb/templates/server/persistence/repositories/Users.js and 1 other location - About 40 mins to fix
generators/persistence-mongodb/templates/server/persistence/repositories/Users.js on lines 30..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function instrument has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function instrument(glob, title, action, dest, changedArgs) {
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/assets.js - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task('html-incr', () => instrument(config.client.html, 'html', empty(), config.client.dist.path, {}));
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/assets.js and 1 other location - About 35 mins to fix
generators/skeleton/templates/gulp/tasks/assets.js on lines 31..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task('assets-incr', () => instrument(config.client.assets, 'asset', empty(), config.client.dist.assets, {}));
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/assets.js and 1 other location - About 35 mins to fix
generators/skeleton/templates/gulp/tasks/assets.js on lines 28..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class NotFoundError extends Error {
  constructor(message) {
    super();
    this.message = message;
    this.httpStatus = 404;
Severity: Minor
Found in generators/server-full/templates/server/errors/not_found.js and 2 other locations - About 30 mins to fix
generators/server-full/templates/server/errors/bad_request.js on lines 1..7
generators/server-full/templates/server/errors/not_authorized.js on lines 1..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class BadRequestError extends Error {
  constructor(message) {
    super();
    this.message = message;
    this.httpStatus = 400;
Severity: Minor
Found in generators/server-full/templates/server/errors/bad_request.js and 2 other locations - About 30 mins to fix
generators/server-full/templates/server/errors/not_authorized.js on lines 1..7
generators/server-full/templates/server/errors/not_found.js on lines 1..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task('assets', () => instrument(config.client.assets, 'asset', empty(), config.client.dist.assets));
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/assets.js and 1 other location - About 30 mins to fix
generators/skeleton/templates/gulp/tasks/assets.js on lines 27..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class NotAuthorizedError extends Error {
  constructor(message) {
    super();
    this.message = message;
    this.httpStatus = 401;
Severity: Minor
Found in generators/server-full/templates/server/errors/not_authorized.js and 2 other locations - About 30 mins to fix
generators/server-full/templates/server/errors/bad_request.js on lines 1..7
generators/server-full/templates/server/errors/not_found.js on lines 1..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task('html', () => instrument(config.client.html, 'html', empty(), config.client.dist.path));
Severity: Minor
Found in generators/skeleton/templates/gulp/tasks/assets.js and 1 other location - About 30 mins to fix
generators/skeleton/templates/gulp/tasks/assets.js on lines 30..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function updateNpmScript has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function updateNpmScript(name, data) {
  const pkg = this.readPackageJson();
  const existing = pkg.scripts && pkg.scripts[name];

  let result = null;
Severity: Minor
Found in util/common-generator/phases/initializing.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language