Sign upLogin

attack/barometer

View on GitHub
Star

Showing 7 of 7 total issues

Class ConvertableUnits has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ConvertableUnits < SimpleDelegator
      include Comparable

      def initialize(*args)
        parse_metric!(args)
Severity: Minor
Found in lib/barometer/data/convertable_units.rb - About 3 hrs to fix

    Class Weather has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Weather
    attr_accessor :responses
    attr_accessor :start_at, :end_at

    def initialize(units=:metric)
    Severity: Minor
    Found in lib/barometer/weather.rb - About 2 hrs to fix

      Method parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def self.parse(*args)
        return unless args.compact.size > 0
        first_arg = args.first

        if first_arg.is_a? ::Time
      Severity: Minor
      Found in lib/barometer/utils/time.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method geo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.geo(query)
          return unless query && query.is_a?(String)
          $:.unshift(File.dirname(__FILE__))
          @@codes ||= YAML.load_file(@@codes_file)
          return unless @@codes && @@codes['one_letter'] && @@codes['two_letter']
      Severity: Minor
      Found in lib/barometer/query/formats/icao.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _find_indirect_converters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def self._find_indirect_converters(from_format, to_formats)
        geocode_converter = find(from_format, :geocode)
        converter = nil
        to_formats.each do |to_format|
          converter = find(:geocode, to_format)
      Severity: Minor
      Found in lib/barometer/query/converter.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module Data
    class Pressure < ConvertableUnits
      def mb; metric; end
      def in; imperial; end
      Severity: Minor
      Found in lib/barometer/data/pressure.rb and 1 other location - About 20 mins to fix
      lib/barometer/data/distance.rb on lines 2..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module Data
    class Distance < ConvertableUnits
      def km; metric; end
      def m; imperial; end
      Severity: Minor
      Found in lib/barometer/data/distance.rb and 1 other location - About 20 mins to fix
      lib/barometer/data/pressure.rb on lines 2..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language