Sign upLogin

attogram/attogram-database

View on GitHub
Star

Showing 7,594 of 7,594 total issues

Function pager has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function pager($count, $limit, $offset, $preQS = '')
    {
        if ($limit > $count) {
            $limit = $count;
        }
Severity: Minor
Found in includes/SqliteDatabase.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function output has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static function output($resource)
    {
        if (isset(self::$_resources[$resource])) {
            $res =& self::$_resources[$resource];
Severity: Minor
Found in admin_actions/db-admin.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method selectArray has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function selectArray($query, $mode="both")
    {
        $result = $this->query($query);
        //make sure the result is valid
        if($result=== false || $result===NULL)
Severity: Minor
Found in admin_actions/db-admin.php - About 1 hr to fix

    Avoid excessively long variable names like $notAllowedCharsIfNone. Keep variable name length under 20.
    Open

        private function sqlite_surroundings_preg($name,$preg_quote=true,$notAllowedCharsIfNone="'\"",$notAllowedName=false)
    Severity: Minor
    Found in admin_actions/db-admin.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $system_password_encrypted. Keep variable name length under 20.
    Open

        private $system_password_encrypted;
    Severity: Minor
    Found in admin_actions/db-admin.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $preg_remove_create_table. Keep variable name length under 20.
    Open

                        $preg_remove_create_table = "/^\s*+CREATE\s++TABLE\s++".$this->sqlite_surroundings_preg($table)."\s*+(\(.*+)$/is";
    Severity: Minor
    Found in admin_actions/db-admin.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $preg_column_definiton. Keep variable name length under 20.
    Open

                            $preg_column_definiton = "\s*+".$this->sqlite_surroundings_preg("+",true," '\"\[`,",$column)."(?:\s*+".$this->sqlite_surroundings_preg("*",false,"'\",`\[ ").")++";        // catches a complete column definition, even if it is
    Severity: Minor
    Found in admin_actions/db-admin.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $preg_column_to_change. Keep variable name length under 20.
    Open

                                    $preg_column_to_change = "\s*".$this->sqlite_surroundings_preg($column)."(?:\s+".preg_quote($coltypes[$column]).")?(\s+(?:".$this->sqlite_surroundings_preg("*",false,",'\"`\[").")+)?";
    Severity: Minor
    Found in admin_actions/db-admin.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            case "view_drop":
            $query = "DROP VIEW ".$db->quote_id($_POST['viewname']);
            $result=$db->query($query);
            if($result===false)
                $error = true;
    Severity: Major
    Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
    admin_actions/db-admin.php on lines 1208..1215

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            case "table_drop":
            $query = "DROP TABLE ".$db->quote_id($_POST['tablename']);
            $result=$db->query($query);
            if($result===false)
                $error = true;
    Severity: Major
    Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
    admin_actions/db-admin.php on lines 1218..1225

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method pager has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function pager($count, $limit, $offset, $preQS = '')
    {
        if ($limit > $count) {
            $limit = $count;
        }
    Severity: Minor
    Found in includes/SqliteDatabase.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      case (FORCETYPE=="SQLite3" || ((FORCETYPE==false || $ver!=-1) && class_exists("SQLite3") && ($ver==-1 || $ver==3))):
                    $this->database = new SQLite3($this->data['path']);
                    if($this->database!=NULL)
                    {
                        $this->type = "SQLite3";
      Severity: Major
      Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
      admin_actions/db-admin.php on lines 4298..4304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      case (FORCETYPE=="SQLiteDatabase" || ((FORCETYPE==false || $ver!=-1) && class_exists("SQLiteDatabase") && ($ver==-1 || $ver==2))):
                    $this->database = new SQLiteDatabase($this->data['path']);
                    if($this->database!=NULL)
                    {
                        $this->type = "SQLiteDatabase";
      Severity: Major
      Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
      admin_actions/db-admin.php on lines 4291..4297

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function showError has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function showError()
    {
        global $lang;
        $classPDO = class_exists("PDO");
        $classSQLite3 = class_exists("SQLite3");
      Severity: Minor
      Found in admin_actions/db-admin.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method select has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function select($query, $mode="both")
    {
        $result = $this->query($query);
        if(!$result) //make sure the result is valid
            return NULL;
      Severity: Minor
      Found in admin_actions/db-admin.php - About 1 hr to fix

        Function loadTableDefinitions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function loadTableDefinitions()
    {
        if (isset($this->tables) && is_array($this->tables)) {
            return true;
        }
        Severity: Minor
        Found in includes/SqliteDatabase.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getAffectedRows has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getAffectedRows()
    {
        if($this->type=="PDO")
            if(!is_object($this->lastResult))
                // in case it was an alter table statement, there is no lastResult object
        Severity: Minor
        Found in admin_actions/db-admin.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tabler has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $table,
        $tableId,
        $nameSingular,
        $namePlural, // TODO - remove unused
        $publicLink,
        Severity: Major
        Found in includes/SqliteDatabase.php - About 1 hr to fix

          Avoid using undefined variables such as '$stack' which will lead to PHP notices.
          Open

              $stack[] = $dir;
          Severity: Minor
          Found in admin_actions/db-admin.php by phpmd

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$stack' which will lead to PHP notices.
          Open

              while($stack)
          Severity: Minor
          Found in admin_actions/db-admin.php by phpmd

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Severity
          Category
          Status
          Source
          Language