attogram/attogram-modulemanager

View on GitHub

Showing 65 of 65 total issues

Trailing punctuation in header
Open

#### 16. Limitation of Liability.
Severity: Info
Found in LICENSE.md by markdownlint

MD026 - Trailing punctuation in header

Tags: headers

Aliases: no-trailing-punctuation

Parameters: punctuation (string; default ".,;:!?")

This rule is triggered on any header that has a punctuation character as the last character in the line:

# This is a header.

To fix this, remove any trailing punctuation:

# This is a header

Note: The punctuation parameter can be used to specify what characters class as punctuation at the end of the header. For example, you can set it to '.,;:!' to allow headers with question marks in them, such as might be used in an FAQ.

Ordered list item prefix
Open

  2. arrange to deprive yourself of the benefit of the patent license for this
Severity: Info
Found in LICENSE.md by markdownlint

MD029 - Ordered list item prefix

Tags: ol

Aliases: ol-prefix

Parameters: style ("one", "ordered"; default "one")

This rule is triggered on ordered lists that do not either start with '1.' or do not have a prefix that increases in numerical order (depending on the configured style, which defaults to 'one').

Example valid list if the style is configured as 'one':

1. Do this.
1. Do that.
1. Done.

Example valid list if the style is configured as 'ordered':

1. Do this.
2. Do that.
3. Done.

Consider starting bulleted lists at the beginning of the line
Open

  - a) Disclaiming warranty or limiting liability differently from the terms of
Severity: Info
Found in LICENSE.md by markdownlint

MD006 - Consider starting bulleted lists at the beginning of the line

Tags: bullet, ul, indentation

Aliases: ul-start-left

This rule is triggered when top level lists don't start at the beginning of a line:

Some text

  * List item
  * List item

To fix, ensure that top level list items are not indented:

Some test

* List item
* List item

Rationale: Starting lists at the beginning of the line means that nested list items can all be indented by the same amount when an editor's indent function or the tab key is used to indent. Starting a list 1 space in means that the indent of the first nested list is less than the indent of the second level (3 characters if you use 4 space tabs, or 1 character if you use 2 space tabs).

Trailing punctuation in header
Open

#### 1. Source Code.
Severity: Info
Found in LICENSE.md by markdownlint

MD026 - Trailing punctuation in header

Tags: headers

Aliases: no-trailing-punctuation

Parameters: punctuation (string; default ".,;:!?")

This rule is triggered on any header that has a punctuation character as the last character in the line:

# This is a header.

To fix this, remove any trailing punctuation:

# This is a header

Note: The punctuation parameter can be used to specify what characters class as punctuation at the end of the header. For example, you can set it to '.,;:!' to allow headers with question marks in them, such as might be used in an FAQ.

Code block style
Open

    <one line to give the program's name and a brief idea of what it does.>
Severity: Info
Found in LICENSE.md by markdownlint

Ordered list item prefix
Open

  2. tells the user that there is no warranty for the work (except to the
Severity: Info
Found in LICENSE.md by markdownlint

MD029 - Ordered list item prefix

Tags: ol

Aliases: ol-prefix

Parameters: style ("one", "ordered"; default "one")

This rule is triggered on ordered lists that do not either start with '1.' or do not have a prefix that increases in numerical order (depending on the configured style, which defaults to 'one').

Example valid list if the style is configured as 'one':

1. Do this.
1. Do that.
1. Done.

Example valid list if the style is configured as 'ordered':

1. Do this.
2. Do that.
3. Done.

Ordered list item prefix
Open

  2. offer you this License giving you legal permission to copy, distribute
Severity: Info
Found in LICENSE.md by markdownlint

MD029 - Ordered list item prefix

Tags: ol

Aliases: ol-prefix

Parameters: style ("one", "ordered"; default "one")

This rule is triggered on ordered lists that do not either start with '1.' or do not have a prefix that increases in numerical order (depending on the configured style, which defaults to 'one').

Example valid list if the style is configured as 'one':

1. Do this.
1. Do that.
1. Done.

Example valid list if the style is configured as 'ordered':

1. Do this.
2. Do that.
3. Done.

Consider starting bulleted lists at the beginning of the line
Open

  - a) The work must carry prominent notices stating that you modified it, and
Severity: Info
Found in LICENSE.md by markdownlint

MD006 - Consider starting bulleted lists at the beginning of the line

Tags: bullet, ul, indentation

Aliases: ul-start-left

This rule is triggered when top level lists don't start at the beginning of a line:

Some text

  * List item
  * List item

To fix, ensure that top level list items are not indented:

Some test

* List item
* List item

Rationale: Starting lists at the beginning of the line means that nested list items can all be indented by the same amount when an editor's indent function or the tab key is used to indent. Starting a list 1 space in means that the indent of the first nested list is less than the indent of the second level (3 characters if you use 4 space tabs, or 1 character if you use 2 space tabs).

Trailing punctuation in header
Open

#### 3. Protecting Users' Legal Rights From Anti-Circumvention Law.
Severity: Info
Found in LICENSE.md by markdownlint

MD026 - Trailing punctuation in header

Tags: headers

Aliases: no-trailing-punctuation

Parameters: punctuation (string; default ".,;:!?")

This rule is triggered on any header that has a punctuation character as the last character in the line:

# This is a header.

To fix this, remove any trailing punctuation:

# This is a header

Note: The punctuation parameter can be used to specify what characters class as punctuation at the end of the header. For example, you can set it to '.,;:!' to allow headers with question marks in them, such as might be used in an FAQ.

Ordered list item prefix
Open

    2. access to copy the Corresponding Source from a network server at no
Severity: Info
Found in LICENSE.md by markdownlint

MD029 - Ordered list item prefix

Tags: ol

Aliases: ol-prefix

Parameters: style ("one", "ordered"; default "one")

This rule is triggered on ordered lists that do not either start with '1.' or do not have a prefix that increases in numerical order (depending on the configured style, which defaults to 'one').

Example valid list if the style is configured as 'one':

1. Do this.
1. Do that.
1. Done.

Example valid list if the style is configured as 'ordered':

1. Do this.
2. Do that.
3. Done.

Trailing punctuation in header
Open

#### 7. Additional Terms.
Severity: Info
Found in LICENSE.md by markdownlint

MD026 - Trailing punctuation in header

Tags: headers

Aliases: no-trailing-punctuation

Parameters: punctuation (string; default ".,;:!?")

This rule is triggered on any header that has a punctuation character as the last character in the line:

# This is a header.

To fix this, remove any trailing punctuation:

# This is a header

Note: The punctuation parameter can be used to specify what characters class as punctuation at the end of the header. For example, you can set it to '.,;:!' to allow headers with question marks in them, such as might be used in an FAQ.

Trailing punctuation in header
Open

#### 13. Use with the GNU Affero General Public License.
Severity: Info
Found in LICENSE.md by markdownlint

MD026 - Trailing punctuation in header

Tags: headers

Aliases: no-trailing-punctuation

Parameters: punctuation (string; default ".,;:!?")

This rule is triggered on any header that has a punctuation character as the last character in the line:

# This is a header.

To fix this, remove any trailing punctuation:

# This is a header

Note: The punctuation parameter can be used to specify what characters class as punctuation at the end of the header. For example, you can set it to '.,;:!' to allow headers with question marks in them, such as might be used in an FAQ.

Code block style
Open

    <program>  Copyright (C) <year>  <name of author>
Severity: Info
Found in LICENSE.md by markdownlint

Variable $this is undeclared
Open

    $results = $manager->enable($this->request->query->get('e'));
Severity: Minor
Found in admin_actions/module-admin.php by phan

Variable $this is undeclared
Open

$this->pageHeader('Module Manager');
Severity: Minor
Found in admin_actions/module-admin.php by phan

Variable $this is undeclared
Open

$manager = new ModuleManager($this);
Severity: Minor
Found in admin_actions/module-admin.php by phan

Variable $this is undeclared
Open

if ($this->request->query->has('d')) {
Severity: Minor
Found in admin_actions/module-admin.php by phan

Variable $this is undeclared
Open

    $this->shutdown();
Severity: Minor
Found in admin_actions/module-admin.php by phan

Suspicious attempt to unset class \Attogram\ModuleManager's property disabledModules declared at /code/includes/ModuleManager.php:14 (This can be done, but is more commonly done for dynamic properties and Phan does not expect this)
Open

        unset($this->disabledModules);
Severity: Info
Found in includes/ModuleManager.php by phan

Variable $result was undeclared, but array fields are being added to it.
Open

        $result['basename'] = basename($moduleDir);
Severity: Info
Found in includes/ModuleManager.php by phan
Severity
Category
Status
Source
Language