checkApache accesses the super-global variable $_SERVER. Open
public function checkApache()
{
isset($_SERVER['SERVER_SOFTWARE'])
? $serverSoftware = $_SERVER['SERVER_SOFTWARE'] : $serverSoftware = '';
$serverSoftwareArray = explode(' ', $serverSoftware);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
check accesses the super-global variable $_SERVER. Open
public function check()
{
$this->pageHeader();
echo '<h1><span class="icon">🔬</span> Attogram Framework Check</h1>'
.'<p><span class="icon">👉</span> <strong>'.__DIR__.'</strong>'
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
goodUri accesses the super-global variable $_SERVER. Open
public function goodUri()
{
$indexFile = '/index.php';
if (!isset($_SERVER['DOCUMENT_ROOT'])) {
return $indexFile;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
checkApache accesses the super-global variable $_SERVER. Open
public function checkApache()
{
isset($_SERVER['SERVER_SOFTWARE'])
? $serverSoftware = $_SERVER['SERVER_SOFTWARE'] : $serverSoftware = '';
$serverSoftwareArray = explode(' ', $serverSoftware);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
goodUri accesses the super-global variable $_SERVER. Open
public function goodUri()
{
$indexFile = '/index.php';
if (!isset($_SERVER['DOCUMENT_ROOT'])) {
return $indexFile;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Function checkHtaccess
has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring. Open
public function checkHtaccess()
{
$htaccessFile = './.htaccess';
file_exists($htaccessFile) ? $result = 'pass' : $result = 'fail';
echo '<pre class="'.$result.'">'.$this->{$result}.' 2.0 - <strong>'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method checkHtaccess
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function checkHtaccess()
{
$htaccessFile = './.htaccess';
file_exists($htaccessFile) ? $result = 'pass' : $result = 'fail';
echo '<pre class="'.$result.'">'.$this->{$result}.' 2.0 - <strong>'
The class AttogramCheck has an overall complexity of 63 which is very high. The configured complexity threshold is 50. Open
class AttogramCheck
{
public $pass;
public $fail;
public $unknown;
- Exclude checks
File check.php
has 304 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
// Attogram Framework - Check Script v0.1.11
namespace Attogram;
Method checkApache
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function checkApache()
{
isset($_SERVER['SERVER_SOFTWARE'])
? $serverSoftware = $_SERVER['SERVER_SOFTWARE'] : $serverSoftware = '';
$serverSoftwareArray = explode(' ', $serverSoftware);
Function apacheConfExamine
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function apacheConfExamine($conf)
{
$thisDir = '';
$allowOverride = array();
$file = new SplFileObject($conf);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method apacheConfExamine
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function apacheConfExamine($conf)
{
$thisDir = '';
$allowOverride = array();
$file = new SplFileObject($conf);
Function checkIndex
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function checkIndex()
{
$indexFile = './index.php';
file_exists($indexFile) ? $fileexists = 'pass' : $fileexists = 'fail';
echo '<pre class="'.$fileexists.'">'.$this->{$fileexists}.' 1.0 - <strong>'.$indexFile.'</strong> exists</pre>';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkApache
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function checkApache()
{
isset($_SERVER['SERVER_SOFTWARE'])
? $serverSoftware = $_SERVER['SERVER_SOFTWARE'] : $serverSoftware = '';
$serverSoftwareArray = explode(' ', $serverSoftware);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method checkHtaccess() has an NPath complexity of 166216. The configured NPath complexity threshold is 200. Open
public function checkHtaccess()
{
$htaccessFile = './.htaccess';
file_exists($htaccessFile) ? $result = 'pass' : $result = 'fail';
echo '<pre class="'.$result.'">'.$this->{$result}.' 2.0 - <strong>'
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method checkHtaccess() has 103 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function checkHtaccess()
{
$htaccessFile = './.htaccess';
file_exists($htaccessFile) ? $result = 'pass' : $result = 'fail';
echo '<pre class="'.$result.'">'.$this->{$result}.' 2.0 - <strong>'
- Exclude checks
The method apacheConfExamine() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function apacheConfExamine($conf)
{
$thisDir = '';
$allowOverride = array();
$file = new SplFileObject($conf);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method checkHtaccess() has a Cyclomatic Complexity of 26. The configured cyclomatic complexity threshold is 10. Open
public function checkHtaccess()
{
$htaccessFile = './.htaccess';
file_exists($htaccessFile) ? $result = 'pass' : $result = 'fail';
echo '<pre class="'.$result.'">'.$this->{$result}.' 2.0 - <strong>'
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Remove error control operator '@' on line 33. Open
public function check()
{
$this->pageHeader();
echo '<h1><span class="icon">🔬</span> Attogram Framework Check</h1>'
.'<p><span class="icon">👉</span> <strong>'.__DIR__.'</strong>'
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Avoid using static access to class '\PDO' in method 'checkPhp'. Open
in_array('sqlite', \PDO::getAvailableDrivers())
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Invalid offset 0
of array type array{}
Open
$result42Found = $apacheFound[0];
- Exclude checks
Call to method __construct
from undeclared class \Attogram\SplFileObject
(Did you mean class \SplFileObject) Open
$file = new SplFileObject($conf);
- Exclude checks
Call to method __construct
from undeclared class \Attogram\SplFileObject
(Did you mean class \SplFileObject) Open
$file = new SplFileObject($indexFile);
- Exclude checks
Invalid offset 0
of array type array{}
Open
$result43 = $this->apacheConfExamine($apacheFound[0]);
- Exclude checks
Call to method __construct
from undeclared class \Attogram\SplFileObject
(Did you mean class \SplFileObject) Open
$file = new SplFileObject($htaccessFile);
- Exclude checks
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (preg_match('/ErrorDocument\s+404/', $val)) {
++$count['ErrorDocument 404'];
if (preg_match('/ErrorDocument\s+404\s+(.*)\s+$/', $val, $match)) {
$found['ErrorDocument 404'] = trim($match[1]);
if (trim($match[1]) == $goodUri) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (preg_match('/FallbackResource/', $val)) {
++$count['FallbackResource'];
if (preg_match('/FallbackResource\s+(.*)\s+$/', $val, $match)) {
$found['FallbackResource'] = trim($match[1]);
if (trim($match[1]) == $goodUri) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (preg_match('/ErrorDocument\s+403/', $val)) {
++$count['ErrorDocument 403'];
if (preg_match('/ErrorDocument\s+403\s+(.*)\s+$/', $val, $match)) {
$found['ErrorDocument 403'] = trim($match[1]);
if (trim($match[1]) == $goodUri) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first side effect is on line 6. Open
<?php
- Exclude checks