attogram/router

View on GitHub

Showing 1 of 1 total issue

The method redirect has a boolean flag argument $exitAfter, which is a certain sign of a Single Responsibility Principle violation.
Confirmed

    public function redirect(string $url, int $httpResponseCode = 301, bool $exitAfter = true)
Severity: Minor
Found in src/Router.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Severity
Category
Status
Source
Language