Sign upLogin

aurasphere/gomorra-sql

View on GitHub
Star

Showing 13 of 13 total issues

Method transitionToNextState has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public AbstractState transitionToNextState(String token) throws CaggiaFaException {
        if (token.equalsIgnoreCase(Keywords.SELECT_KEYWORD)) {
            queryInfo.setType(QueryType.SELECT);
            return new SelectColumnsState(queryInfo);
Severity: Minor
Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java - About 1 hr to fix

    Method execute has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public GomorraSqlQueryResult execute(String gomorraSqlQuery) {
        QueryInfo queryInfo = parseQuery(gomorraSqlQuery);
        String sqlQuery = buildSqlQuery(queryInfo);
        GomorraSqlQueryResult result = new GomorraSqlQueryResult();
    Severity: Minor
    Found in src/main/java/co/aurasphere/gomorrasql/GomorraSqlInterpreter.java - About 1 hr to fix

      Method main has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static void main(String[] args) throws Exception {
        Scanner scanner = new Scanner(System.in, StandardCharsets.ISO_8859_1.name());
        System.out.print("Insert a JDBC string to connect to a database: ");
        String url = scanner.nextLine();
        Connection connection = DriverManager.getConnection(url);
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/GomorraSqlShell.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transitionToNextState has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public AbstractState transitionToNextState(String token) throws CaggiaFaException {
        if (token.equals(",")) {
            if (lastWasComma) {
                // Case ", ,"
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/states/CommaSeparedValuesState.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transitionToNextState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public AbstractState transitionToNextState(String token) throws CaggiaFaException {
        if (Keywords.WHERE_OPERATORS.contains(token) || token.equalsIgnoreCase(Keywords.IS_KEYWORD)) {
            if (token.equalsIgnoreCase(Keywords.IS_NOT_KEYWORDS[0])) {
                condition.setOperator("IS NOT");
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/states/where/WhereOperatorState.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transitionToNextState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public AbstractState transitionToNextState(String token) throws CaggiaFaException {
        if (token.equalsIgnoreCase(Keywords.SELECT_KEYWORD)) {
            queryInfo.setType(QueryType.SELECT);
            return new SelectColumnsState(queryInfo);
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (token.equalsIgnoreCase(Keywords.COMMIT_KEYWORDS[0])) {
            queryInfo.setType(QueryType.COMMIT);
            return new GreedyMatchKeywordState(queryInfo, Keywords.COMMIT_KEYWORDS, FinalState::new);
        }
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java and 1 other location - About 30 mins to fix
      src/main/java/co/aurasphere/gomorrasql/states/InitialState.java on lines 62..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  return new GreedyMatchKeywordState(queryInfo, Keywords.ASTERISK_KEYWORDS,
                    q -> new GreedyMatchKeywordState(q, Keywords.FROM_KEYWORDS,
                            q2 -> new AnyTokenConsumerState(q2, q2::setTableName, OptionalWhereState::new), 0));
      Severity: Minor
      Found in src/main/java/co/aurasphere/gomorrasql/states/query/SelectColumnsState.java and 1 other location - About 30 mins to fix
      src/main/java/co/aurasphere/gomorrasql/states/InitialState.java on lines 42..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this method.
      Open

                  return new GreedyMatchKeywordState(queryInfo, Keywords.BEGIN_TRANSACTION_KEYWORDS, FinalState::new);
      Severity: Major
      Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    return new GreedyMatchKeywordState(queryInfo, Keywords.DELETE_KEYWORDS,
                    q -> new GreedyMatchKeywordState(q, Keywords.FROM_KEYWORDS,
                            q2 -> new AnyTokenConsumerState(q2, q2::setTableName, OptionalWhereState::new), 0));
        Severity: Minor
        Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java and 1 other location - About 30 mins to fix
        src/main/java/co/aurasphere/gomorrasql/states/query/SelectColumnsState.java on lines 29..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (token.equalsIgnoreCase(Keywords.BEGIN_TRANSACTION_KEYWORDS[0])) {
            queryInfo.setType(QueryType.BEGIN_TRANSACTION);
            return new GreedyMatchKeywordState(queryInfo, Keywords.BEGIN_TRANSACTION_KEYWORDS, FinalState::new);
        }
        Severity: Minor
        Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java and 1 other location - About 30 mins to fix
        src/main/java/co/aurasphere/gomorrasql/states/InitialState.java on lines 54..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                    return new GreedyMatchKeywordState(queryInfo, Keywords.COMMIT_KEYWORDS, FinalState::new);
        Severity: Major
        Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new FinalState(queryInfo);
          Severity: Major
          Found in src/main/java/co/aurasphere/gomorrasql/states/InitialState.java - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language