aurelia/aurelia

View on GitHub
packages/__tests__/src/3-runtime-html/integration.spec.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getTestData has 378 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function* getTestData() {
    {
      @customElement({ name: 'app', template: '<div ref="container" id="cr">1</div><child ref="child" id="child"></child><div ref="container2" id="cr2">11</div>' })
      class App {
        public readonly container: HTMLElement = void 0;
Severity: Major
Found in packages/__tests__/src/3-runtime-html/integration.spec.ts - About 1 day to fix

    File integration.spec.ts has 470 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
      Class,
      IContainer,
    } from '@aurelia/kernel';
    import {
    Severity: Minor
    Found in packages/__tests__/src/3-runtime-html/integration.spec.ts - About 7 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            @customElement({ name: 'app', template: '<div ref="container" id="cr">1</div><child ref="child" id="child"></child><div ref="container2" id="cr2">11</div>' })
            class App {
              public readonly container: HTMLElement = void 0;
              public readonly child: HTMLElement;
            }
      Severity: Minor
      Found in packages/__tests__/src/3-runtime-html/integration.spec.ts and 1 other location - About 35 mins to fix
      packages/__tests__/src/3-runtime-html/integration.spec.ts on lines 103..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            @customElement({ name: 'child', template: '<div ref="container" id="cc">2</div><grand-child ref="grandChild" id="grandChild"></grand-child><div ref="container2" id="cc2">22</div>' })
            class Child {
              public readonly container: HTMLElement = void 0;
              public readonly grandChild: HTMLElement;
            }
      Severity: Minor
      Found in packages/__tests__/src/3-runtime-html/integration.spec.ts and 1 other location - About 35 mins to fix
      packages/__tests__/src/3-runtime-html/integration.spec.ts on lines 98..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status