Sign upLogin

aurelia/aurelia

View on GitHub
Star
packages/__tests__/src/router/_shared/hook-rules.ts

Summary

Maintainability
F
2 wks
Test Coverage

Function getViewportHooks has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

function getViewportHooks(swapStrategy: SwapStrategy, phase: string, viewport: Viewport, type: '' | 'activate' | 'deactivate' = ''): string[] {
  const hooks = [];
  switch (type) {
    case 'activate':
      if (!viewport.to.isEmpty) {
Severity: Minor
Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getViewportHooks has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getViewportHooks(swapStrategy: SwapStrategy, phase: string, viewport: Viewport, type: '' | 'activate' | 'deactivate' = ''): string[] {
  const hooks = [];
  switch (type) {
    case 'activate':
      if (!viewport.to.isEmpty) {
Severity: Major
Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 3 hrs to fix

    Function getViewports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getViewports(root: string, from: string, to: string): {
  viewports: Viewport[];
  topViewport: Viewport;
  fromViewports: Viewport[];
  toViewports: Viewport[];
    Severity: Minor
    Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 1 hr to fix

      Function verifyDeactivateHooksOrder has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function verifyDeactivateHooksOrder(invocations: string[], phase: string, viewports: Viewport[]): boolean {
  for (let i = viewports.length - 1; i > 0; i--) {
    if (!verifyHookOrder(invocations,
      `${phase}:${viewports[i].name}.${viewports[i].from.name}.detaching.enter`,
      `${phase}:${viewports[i - 1].name}.${viewports[i - 1].from.name}.detaching.enter`)
      Severity: Minor
      Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 1 hr to fix

        Function getViewports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function getViewports(root: string, from: string, to: string): {
  viewports: Viewport[];
  topViewport: Viewport;
  fromViewports: Viewport[];
  toViewports: Viewport[];
        Severity: Minor
        Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function verifyRules has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function verifyRules(invocations: string[], swapStrategy: SwapStrategy, phase: string, root: string, from: string, to: string): boolean {
  const {
    viewports,
    topViewport,
    fromViewports,
        Severity: Minor
        Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 1 hr to fix

          Function verifyDeactivateHooksOrder has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function verifyDeactivateHooksOrder(invocations: string[], phase: string, viewports: Viewport[]): boolean {
  for (let i = viewports.length - 1; i > 0; i--) {
    if (!verifyHookOrder(invocations,
      `${phase}:${viewports[i].name}.${viewports[i].from.name}.detaching.enter`,
      `${phase}:${viewports[i - 1].name}.${viewports[i - 1].from.name}.detaching.enter`)
          Severity: Minor
          Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function verifyRules has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function verifyRules(invocations: string[], swapStrategy: SwapStrategy, phase: string, root: string, from: string, to: string): boolean {
          Severity: Minor
          Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 45 mins to fix

            Function verifyRules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            export function verifyRules(invocations: string[], swapStrategy: SwapStrategy, phase: string, root: string, from: string, to: string): boolean {
  const {
    viewports,
    topViewport,
    fromViewports,
            Severity: Minor
            Found in packages/__tests__/src/router/_shared/hook-rules.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (!viewport.to.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.leave`);
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 148..157
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 176..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 337.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      if (!viewport.to.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.leave`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 98..107
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 148..157

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 337.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      if (!viewport.to.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.leave`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.bound.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 98..107
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 176..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 337.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      if (!viewport.from.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.leave`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 110..117
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 168..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 257.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      if (!viewport.from.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.leave`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.enter`);
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 110..117
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 158..165

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 257.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (!viewport.from.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.leave`);
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unbinding.leave`);
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 2 other locations - About 1 day to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 158..165
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 168..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 257.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              for (let i = viewports.length - 1; i > 0; i--) {
    if (!verifyHookOrder(invocations,
      `${phase}:${viewports[i].name}.${viewports[i].from.name}.detaching.enter`,
      `${phase}:${viewports[i - 1].name}.${viewports[i - 1].from.name}.detaching.enter`)
    ) {
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 1 other location - About 5 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 57..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 144.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              for (let i = viewports.length - 1; i > 0; i--) {
    if (!verifyHookOrder(invocations,
      `${phase}:${viewports[i].name}.${viewports[i].from.name}.unbinding.enter`,
      `${phase}:${viewports[i - 1].name}.${viewports[i - 1].from.name}.unbinding.enter`)
    ) {
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 1 other location - About 5 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 48..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 144.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  if (!viewport.to.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.canLoad.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.canLoad.leave`);
      }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 3 other locations - About 3 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 120..123
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 128..131
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 132..135

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  if (!viewport.from.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unloading.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.unloading.leave`);
      }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 3 other locations - About 3 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 120..123
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 124..127
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 132..135

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  if (!viewport.to.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.loading.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.loading.leave`);
      }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 3 other locations - About 3 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 120..123
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 124..127
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 128..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  if (!viewport.from.isEmpty) {
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.canUnload.enter`);
        hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.canUnload.leave`);
      }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 3 other locations - About 3 hrs to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 124..127
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 128..131
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 132..135

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if (!viewport.from.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.from.name}.detaching.enter`);
          }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 1 other location - About 1 hr to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 143..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if (!viewport.to.isEmpty) {
            hooks.push(`${phase}:${viewport.name}.${viewport.to.name}.binding.enter`);
          }
            Severity: Major
            Found in packages/__tests__/src/router/_shared/hook-rules.ts and 1 other location - About 1 hr to fix
            packages/__tests__/src/router/_shared/hook-rules.ts on lines 140..142

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status