aurelia/aurelia

File router.lifecycle-hooks.spec.ts has 374 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { IContainer } from '@aurelia/kernel';
import { IRoute, IRouter, IRouterOptions, RouterConfiguration } from '@aurelia/router';
import { Aurelia, CustomElement, IPlatform, lifecycleHooks } from '@aurelia/runtime-html';
import { MockBrowserHistoryLocation, TestContext, assert } from '@aurelia/testing';

Function _expected has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      function _expected($config: typeof config) {
        let oneLoaded = false;
        let twoChecked = false;
        let twoLoaded = false;
        const expected = [];

Function _expected has 51 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      function _expected(config: typeof configs[0]) {
        let oneLoaded = false;
        let twoChecked = false;
        // let twoLoaded = false;
        const expected = [];

Function $setup has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async function $setup(
    config?: IRouterOptions,
    dependencies: any[] = [],
    routes: IRoute[] = [],
    stateSpy: NavigationStateSpy = void 0,

Function _elements has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function _elements(config, calledHooks) {
      @lifecycleHooks()
      class Hooks {
        name = 'Hooks';
        canLoad(vm) { calledHooks.push(`${this.name}:${vm.name}:canLoad`); return config.Hooks_canLoad; }

Avoid deeply nested control flow statements.

Open

              if (config.Two_canUnload) {
                expected.push('Hooks:my-two:unloading', 'VM:my-two:unloading');
                // two = false;
              }

Avoid deeply nested control flow statements.

Open

              if ($config.Two_canUnload) {
                expected.push('Hooks:my-two:unloading', 'VM:my-two:unloading');
                // two = false;
              }

Avoid too many return statements within this function.

Open

        return expected;

Avoid too many return statements within this function.

Open

        if (!config.Two_canUnload) return expected;

Avoid too many return statements within this function.

Open

        if (!config.One_canUnload) return expected;

Avoid too many return statements within this function.

Open

        return expected;

Avoid too many return statements within this function.

Open

        if (!config.One_canUnload) return expected;

Avoid too many return statements within this function.

Open

        if (!config.Two_canUnload) return expected;

Similar blocks of code found in 7 locations. Consider refactoring.

Open

  async function $setup(
    config?: IRouterOptions,
    dependencies: any[] = [],
    routes: IRoute[] = [],
    stateSpy: NavigationStateSpy = void 0,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const One = CustomElement.define({ name: 'my-one', template: '!my-one!<au-viewport></au-viewport>', dependencies: [Hooks] },
        class {
          public name = 'my-one';
          public canLoad() { calledHooks.push(`VM:${this.name}:canLoad`); /* return config.One_canLoad; */ return new Promise((res) => { setTimeout(() => res(config.One_canLoad), 100); }); }
          public loading() { calledHooks.push(`VM:${this.name}:loading`); return new Promise((res) => { setTimeout(() => res(void 0), 50); }); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const Two = CustomElement.define({ name: 'my-two', template: '!my-two!', dependencies: [Hooks] },
        class {
          public name = 'my-two';
          public canLoad() { calledHooks.push(`VM:${this.name}:canLoad`); /* return config.Two_canLoad; */ return new Promise((res) => { setTimeout(() => res(config.Two_canLoad), 100); }); }
          public loading() { calledHooks.push(`VM:${this.name}:loading`); return new Promise((res) => { setTimeout(() => res(void 0), 50); }); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const configs = [
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: false, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: false, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: false, Two_canUnload: true },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const configs = [
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: false, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: false, One_canUnload: true, Two_canLoad: true, Two_canUnload: true },
      { Hooks_canLoad: true, Hooks_canUnload: true, One_canLoad: true, One_canUnload: true, Two_canLoad: false, Two_canUnload: true },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const One = CustomElement.define({ name: 'my-one', template: '!my-one!<au-viewport></au-viewport>', dependencies: [Hooks] },
        class {
          name = 'my-one';
          canLoad() { calledHooks.push(`VM:${this.name}:canLoad`); return config.One_canLoad; }
          loading() { calledHooks.push(`VM:${this.name}:loading`); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const Two = CustomElement.define({ name: 'my-two', template: '!my-two!', dependencies: [Hooks] },
        class {
          name = 'my-two';
          canLoad() { calledHooks.push(`VM:${this.name}:canLoad`); return config.Two_canLoad; }
          loading() { calledHooks.push(`VM:${this.name}:loading`); }

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

  function spyNavigationStates(router: IRouter, spy?: NavigationStateSpy) {
    let _pushState;
    let _replaceState;
    if (spy) {
      _pushState = router.viewer.location.pushState;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      it(`with hook and vm (falses: ${_falses(config)})`, async function () {
        const { platform, router, $teardown } = await $setup({}, [Hooks, One, Two]);

        const expected = _expected(config);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      it(`with hook and vm (falses: ${_falses(config)})`, async function () {
        const { platform, router, $teardown } = await $setup({}, [Hooks, One, Two]);

        const expected = _expected(config);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      it(`in parent-child with hook and vm (falses: ${_falses(config)})`, async function () {
        const { platform, router, $teardown } = await $setup({}, [Hooks, One, Two]);

        await $load('/my-one/my-two', router, platform);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      it(`in parent-child with hook and vm (falses: ${_falses(config)})`, async function () {
        const { platform, router, $teardown } = await $setup({}, [Hooks, One, Two]);

        await $load('/my-one/my-two', router, platform);
        await $load('-', router, platform);

• Read up
  Read up

Identical blocks of code found in 9 locations. Consider refactoring.

Open

  function getModifiedRouter(container: IContainer) {
    const router = container.get(IRouter) as IRouter;
    const mockBrowserHistoryLocation = new MockBrowserHistoryLocation();
    mockBrowserHistoryLocation.changeCallback = async (ev) => { router.viewer.handlePopStateEvent(ev); };
    router.viewer.history = mockBrowserHistoryLocation as any;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function _falses(config: typeof configs[0]) {
      const falses = [];
      for (const [key, value] of Object.entries(config)) {
        if (!value) {
          falses.push(key);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function _falses($config: typeof configs[0]) {
      const falses = [];
      for (const [key, value] of Object.entries($config)) {
        if (!value) {
          falses.push(key);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        public async canLoad(vm: Vm) { calledHooks.push(`${this.name}:${vm.name}:canLoad`); /* return config.Hooks_canLoad; */ return new Promise((res) => { setTimeout(() => res(config.Hooks_canLoad), 100); }); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        public async canUnload(vm: Vm) { calledHooks.push(`${this.name}:${vm.name}:canUnload`); /* return config.Hooks_canUnload; */ return new Promise((res) => { setTimeout(() => res(config.Hooks_canUnload), 100); }); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        public async loading(vm: Vm) { calledHooks.push(`${this.name}:${vm.name}:loading`); return new Promise((res) => { setTimeout(() => res(void 0), 75); }); }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        public async unloading(vm: Vm) { calledHooks.push(`${this.name}:${vm.name}:unloading`); return new Promise((res) => { setTimeout(() => res(void 0), 75); }); }

• Read up
  Read up

Identical blocks of code found in 10 locations. Consider refactoring.

Open

const $load = async (path: string, router: IRouter, platform: IPlatform) => {
  await router.load(path);
  platform.domQueue.flush();
};

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

  function unspyNavigationStates(router, _push, _replace) {
    if (_push) {
      router.viewer.location.pushState = _push;
      router.viewer.location.replaceState = _replace;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        canLoad(vm) { calledHooks.push(`${this.name}:${vm.name}:canLoad`); return config.Hooks_canLoad; }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        canUnload(vm) { calledHooks.push(`${this.name}:${vm.name}:canUnload`); return config.Hooks_canUnload; }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (config.Hooks_canUnload) {
              expected.push('VM:my-two:canUnload');
              if (config.Two_canUnload) {
                expected.push('Hooks:my-two:unloading', 'VM:my-two:unloading');
                // two = false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if ($config.Hooks_canUnload) {
              expected.push('VM:my-two:canUnload');
              if ($config.Two_canUnload) {
                expected.push('Hooks:my-two:unloading', 'VM:my-two:unloading');
                // two = false;

• Read up
  Read up