Sign upLogin

aurelia/aurelia

View on GitHub
Star
packages/testing/src/string-manipulation.ts

Summary

Maintainability
D
2 days
Test Coverage

Function jsonStringify has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export function jsonStringify(
  o: unknown,
  ctx: { result: string },
): string {
  if (ctx.result.length > 100) {
Severity: Minor
Found in packages/testing/src/string-manipulation.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function htmlStringify has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

export function htmlStringify(
  node: object & { nodeName?: string; content?: any; innerHTML?: string; textContent?: string; childNodes?: ArrayLike<object>; nodeType?: number },
  ctx: { result: string },
): string {
  if (ctx.result.length > 100) {
Severity: Minor
Found in packages/testing/src/string-manipulation.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jsonStringify has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function jsonStringify(
  o: unknown,
  ctx: { result: string },
): string {
  if (ctx.result.length > 100) {
Severity: Minor
Found in packages/testing/src/string-manipulation.ts - About 1 hr to fix

    Function htmlStringify has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function htmlStringify(
  node: object & { nodeName?: string; content?: any; innerHTML?: string; textContent?: string; childNodes?: ArrayLike<object>; nodeType?: number },
  ctx: { result: string },
): string {
  if (ctx.result.length > 100) {
    Severity: Minor
    Found in packages/testing/src/string-manipulation.ts - About 1 hr to fix

      Function stringify has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function stringify(
  value: any,
  ctx: { result: string },
): string {
  const Type = toStringTag.call(value);
      Severity: Minor
      Found in packages/testing/src/string-manipulation.ts - About 1 hr to fix

        Function stringify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function stringify(
  value: any,
  ctx: { result: string },
): string {
  const Type = toStringTag.call(value);
        Severity: Minor
        Found in packages/testing/src/string-manipulation.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return value;
        Severity: Major
        Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return ret;
          Severity: Major
          Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return void 0 as unknown as string;
            Severity: Major
            Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return ret;
              Severity: Major
              Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return `${ret.slice(0, 10)}...(+${len - 10})`;
                Severity: Major
                Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return val;
                  Severity: Major
                  Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return htmlStringify(node.content, ctx);
                    Severity: Major
                    Found in packages/testing/src/string-manipulation.ts - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        if ((node.textContent != null && node.textContent.length) || node.nodeType === 3 /* Text */ || node.nodeType === 8 /* Comment */) {
    const ret = node.textContent!.replace(newline, '');
    if (ret.length > 10) {
      const len = ret.length;
      return `${ret.slice(0, 10)}...(+${len - 10})`;
                      Severity: Major
                      Found in packages/testing/src/string-manipulation.ts and 1 other location - About 2 hrs to fix
                      packages/testing/src/string-manipulation.ts on lines 139..146

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 81.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (node.innerHTML!.length) {
      const ret = node.innerHTML!.replace(newline, '');
      if (ret.length > 10) {
        const len = ret.length;
        return `${ret.slice(0, 10)}...(+${len - 10})`;
                      Severity: Major
                      Found in packages/testing/src/string-manipulation.ts and 1 other location - About 2 hrs to fix
                      packages/testing/src/string-manipulation.ts on lines 130..137

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 81.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status