Sign upLogin

aureooms/js-d-ary-heap

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

DAryHeap.prototype.decreasekey = function (reference, value) {
    const a = this.array;
    const i = 0;
    const j = a.length;
    const k = reference.index;
Severity: Major
Found in src/adt/DAryHeap.js and 1 other location - About 3 hrs to fix
src/adt/DAryHeap.js on lines 175..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

DAryHeap.prototype.increasekey = function (reference, value) {
    const a = this.array;
    const i = 0;
    const j = a.length;
    const k = reference.index;
Severity: Major
Found in src/adt/DAryHeap.js and 1 other location - About 3 hrs to fix
src/adt/DAryHeap.js on lines 164..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function merge has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

export default function merge(arity, compare, swap, a, i, j, k) {
Severity: Major
Found in src/core/merge.js - About 50 mins to fix

    Function remove has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export default function remove(arity, compare, swap, a, i, j, k) {
    Severity: Major
    Found in src/core/remove.js - About 50 mins to fix

      Function siftup has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export default function siftup(arity, compare, swap, a, i, j, k) {
      Severity: Major
      Found in src/core/siftup.js - About 50 mins to fix

        Function pull has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export default function pull(arity, compare, swap, a, i, j, k) {
        Severity: Major
        Found in src/core/pull.js - About 50 mins to fix

          Function siftdown has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export default function siftdown(arity, compare, swap, a, i, j, k) {
          Severity: Major
          Found in src/core/siftdown.js - About 50 mins to fix

            Function makeheap has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export default function makeheap(arity, compare, swap, a, i, j) {
            Severity: Minor
            Found in src/core/makeheap.js - About 45 mins to fix

              Function sorted has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              export default function* sorted(arity, compare, swap, a, i, j) {
              Severity: Minor
              Found in src/core/sorted.js - About 45 mins to fix

                Function nextchild has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                export default function nextchild(arity, compare, swap, a, i, j) {
                Severity: Minor
                Found in src/core/nextchild.js - About 45 mins to fix

                  Function pop has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  export default function pop(arity, compare, swap, a, i, j) {
                  Severity: Minor
                  Found in src/core/pop.js - About 45 mins to fix

                    Function push has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    export default function push(arity, compare, swap, a, i, j) {
                    Severity: Minor
                    Found in src/core/push.js - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language