aureooms/js-integer-little-endian

View on GitHub

Showing 44 of 44 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const _sub = function ( r , a, ai, aj, b, bi, bj, c, ci, cj){
    var T, C = 0;

    while(--bj >= bi){
        --aj; --cj;
Severity: Major
Found in src/1-new/arithmetic/sub/_sub.js and 1 other location - About 1 day to fix
src/0-legacy/arithmetic/sub/sub.js on lines 22..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 204.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return function(a, ai, aj, b, bi, bj, c, ci, cj){
        var T, C = 0;

        while(--bj >= bi){
            --aj; --cj;
Severity: Major
Found in src/0-legacy/arithmetic/sub/sub.js and 1 other location - About 1 day to fix
src/1-new/arithmetic/sub/_sub.js on lines 18..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 204.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    return function(a, ai, aj, b, bi, bj){

        var tmp = aj - bj + bi;

        for (; ai < tmp; ++ai)
Severity: Major
Found in src/0-legacy/compare/cmp.js and 1 other location - About 3 hrs to fix
src/1-new/compare/_CMP.js on lines 15..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

export function _CMP (a, ai, aj, b, bi, bj){

    var tmp = aj - bj + bi;

    for (; ai < tmp; ++ai)
Severity: Major
Found in src/1-new/compare/_CMP.js and 1 other location - About 3 hrs to fix
src/0-legacy/compare/cmp.js on lines 18..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function bkaratsuba_t has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

export function bkaratsuba_t (add, sub, mul, calloc, mov, r, wrap){

    /**
     * Multiply two big endian arrays using karatsuba algorithm,
     * i >= j, k >= 2 * i
Severity: Minor
Found in src/0-legacy/arithmetic/mul/karatsuba.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bdiv_t has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

export function bdiv_t (lt, sub){

    /**
     * Computes quotient and remainder of two big endian arrays.
     * <p>
Severity: Minor
Found in src/0-legacy/arithmetic/div/div.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bkaratsuba_t has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function bkaratsuba_t (add, sub, mul, calloc, mov, r, wrap){

    /**
     * Multiply two big endian arrays using karatsuba algorithm,
     * i >= j, k >= 2 * i
Severity: Minor
Found in src/0-legacy/arithmetic/mul/karatsuba.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function _convert_to_larger ( f , t , a , ai , aj , b , bi , bj ) {
    
        const [ z , x ] = _log( t , f ) ;
    
        if ( x === 1 ) return _convert_to_larger_fast( f , z , a , ai , aj , b , bi , bj ) ;
    Severity: Major
    Found in src/1-new/convert/_convert_to_larger.js and 1 other location - About 1 hr to fix
    src/1-new/convert/_convert_to_smaller.js on lines 15..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function _convert_to_smaller ( f , t , a , ai , aj , b , bi , bj ) {
    
        const [ z , x ] = _log( f , t ) ;
    
        if ( x === 1 ) return _convert_to_smaller_fast( t , z , a , ai , aj , b , bi , bj ) ;
    Severity: Major
    Found in src/1-new/convert/_convert_to_smaller.js and 1 other location - About 1 hr to fix
    src/1-new/convert/_convert_to_larger.js on lines 15..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function karatsuba has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var karatsuba = function(a, ai, aj, b, bi, bj, c, ci, cj){
    
            var z0, z2, t1, t2, t3, n, I, N, N_, i_, j_, i, j, k;
    
            i = aj - ai;
    Severity: Minor
    Found in src/0-legacy/arithmetic/mul/karatsuba.js - About 1 hr to fix

      Function _div has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      export function _div ( x , r , ri , rj , b , bi , bj , q , qi ) {
      
          var k, t = ri + 1;
      
          do {
      Severity: Minor
      Found in src/1-new/arithmetic/div/_div.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _sub has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export const _sub = function ( r , a, ai, aj, b, bi, bj, c, ci, cj){
      Severity: Major
      Found in src/1-new/arithmetic/sub/_sub.js - About 1 hr to fix

        Function bmul_t has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        export function bmul_t (r){
        
            /**
             * Computes product of two big endian arrays.
             * <p>
        Severity: Minor
        Found in src/0-legacy/arithmetic/mul/mul.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mul has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var mul = function(a, ai, aj, b, bi, bj, c, ci, cj){
        Severity: Major
        Found in src/0-legacy/arithmetic/mul/mul.js - About 1 hr to fix

          Function _div has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function _div ( x , r , ri , rj , b , bi , bj , q , qi ) {
          Severity: Major
          Found in src/1-new/arithmetic/div/_div.js - About 1 hr to fix

            Function mul has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                var mul = function(a, ai, aj, b, bi, bj, c, ci, cj){
            Severity: Major
            Found in src/0-legacy/arithmetic/mul/mul53.js - About 1 hr to fix

              Function karatsuba has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  var karatsuba = function(a, ai, aj, b, bi, bj, c, ci, cj){
              Severity: Major
              Found in src/0-legacy/arithmetic/mul/karatsuba.js - About 1 hr to fix

                Function pow has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    var pow = function (a, ai, aj, b, bi, bj, c, ci, cj) {
                Severity: Major
                Found in src/0-legacy/others/pow/pow.js - About 1 hr to fix

                  Function mul has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      var mul = function(a, ai, aj, b, bi, bj, c, ci, cj){
                  Severity: Major
                  Found in src/0-legacy/arithmetic/mul/mul53.js - About 1 hr to fix

                    Function ebs has 9 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        var ebs = function (a, ai, aj, b, bi, bj, c, ci, cj) {
                    Severity: Major
                    Found in src/0-legacy/others/pow/ebs.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language