Sign upLogin

aureooms/js-merging

View on GitHub
Star

Showing 12 of 12 total issues

Function iterables has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export function* iterables ( compare , A , B ) {

    A = A[Symbol.iterator]( ) ;
    B = B[Symbol.iterator]( ) ;
Severity: Minor
Found in src/iterable/iterables.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _hlstatic has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export function _hlstatic ( binarysearch , copy ) {

    /**
     * Merges 2 arrays using the Hwang Lin algorithm.
     *
Severity: Minor
Found in src/array/_hlstatic.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function iterables has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function* iterables ( compare , A , B ) {

    A = A[Symbol.iterator]( ) ;
    B = B[Symbol.iterator]( ) ;
Severity: Minor
Found in src/iterable/iterables.js - About 1 hr to fix

    Function tapemerge has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export function tapemerge ( compare , a , ai , aj , b , bi , bj , c , ci ) {
    Severity: Major
    Found in src/array/tapemerge.js - About 1 hr to fix

      Function hwanglin has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          let hwanglin = function ( compare , a , ai , aj , b , bi , bj , c , ci ) {
      Severity: Major
      Found in src/array/_hlstatic.js - About 1 hr to fix

        Function merge has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            let merge = function ( compare, a, ai, aj, b, bi, bj, c, ci ) {
        Severity: Major
        Found in src/array/_merge.js - About 1 hr to fix

          Function _hlstatic has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function _hlstatic ( binarysearch , copy ) {

    /**
     * Merges 2 arrays using the Hwang Lin algorithm.
     *
          Severity: Minor
          Found in src/array/_hlstatic.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    else {

            yield b ;

            _b = B.next( ) ;
            Severity: Major
            Found in src/iterable/iterables.js and 1 other location - About 1 hr to fix
            src/iterable/iterables.js on lines 22..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( compare( a , b ) <= 0 ) {

            yield a ;

            _a = A.next( ) ;
            Severity: Major
            Found in src/iterable/iterables.js and 1 other location - About 1 hr to fix
            src/iterable/iterables.js on lines 40..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function nodes has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function nodes ( compare , A , m , B , n ) {
            Severity: Minor
            Found in src/nodes/nodes.js - About 35 mins to fix

              Function nodes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              export function nodes ( compare , A , m , B , n ) {

    if ( m <= 0 ) return B ;
    if ( n <= 0 ) return A ;
              Severity: Minor
              Found in src/nodes/nodes.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function tapemerge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              export function tapemerge ( compare , a , ai , aj , b , bi , bj , c , ci ) {

    var cj ;

    cj = ci + aj - ai + bj - bi ;
              Severity: Minor
              Found in src/array/tapemerge.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language