aureooms/js-metaheuristics

View on GitHub

Showing 11 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function first_and_equal ( [ solution , current ] , walk , evaluate ) {

    for ( const mutation of walk( solution ) ) {

        const fitness = evaluate( solution , mutation ) ;
Severity: Major
Found in src/pivoting/first_and_equal.js and 1 other location - About 1 hr to fix
src/pivoting/first.js on lines 8..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function first ( [ solution , current ] , walk , evaluate ) {

    for ( const mutation of walk( solution ) ) {

        const fitness = evaluate( solution , mutation ) ;
Severity: Major
Found in src/pivoting/first.js and 1 other location - About 1 hr to fix
src/pivoting/first_and_equal.js on lines 8..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function TS has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export function* TS ( [ solution , best ] , tabu_is , tabu_set , walk , evaluate , apply ) {

    while ( true ) {

        let candidate = null ;
Severity: Minor
Found in src/globalsearch/TS.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SA has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

export function* SA ( [ solution , best ] , pivoting , walk , evaluate , accept , apply , improvement , temperature , cooldown ) {
Severity: Major
Found in src/globalsearch/SA.js - About 1 hr to fix

    Function RII has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export function* RII ( [ solution , best ] , pivote , pivoting , random , walk , apply , evaluate ) {
    Severity: Major
    Found in src/globalsearch/RII.js - About 50 mins to fix

      Function IG has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function* IG ( [ solution , best ] , localsearch , alter , pivoting , walk , evaluate ) {
      Severity: Minor
      Found in src/globalsearch/IG.js - About 45 mins to fix

        Function TS has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export function* TS ( [ solution , best ] , tabu_is , tabu_set , walk , evaluate , apply ) {
        Severity: Minor
        Found in src/globalsearch/TS.js - About 45 mins to fix

          Function II has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function* II ( [ solution , current ] , pivoting , walk , evaluate , apply ) {
          Severity: Minor
          Found in src/localsearch/II.js - About 35 mins to fix

            Function PII has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function* PII ( [ solution , best ] , random , accept , evaluate , apply ) {
            Severity: Minor
            Found in src/globalsearch/PII.js - About 35 mins to fix

              Function RII has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              export function* RII ( [ solution , best ] , pivote , pivoting , random , walk , apply , evaluate ) {
              
                  while ( true ) {
              
                      if ( pivote( ) ) {
              Severity: Minor
              Found in src/globalsearch/RII.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function SA has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              export function* SA ( [ solution , best ] , pivoting , walk , evaluate , accept , apply , improvement , temperature , cooldown ) {
              
                  let t = temperature ;
                  let candidate = solution ;
                  let current = best ;
              Severity: Minor
              Found in src/globalsearch/SA.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language