aureooms/js-modular-arithmetic-big-endian

View on GitHub

Showing 7 of 7 total issues

Function _redc has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

export default function _redc(b, k, N, Ni, Nj, M, Mi, Mj, T, Ti, Tj) {
Severity: Major
Found in src/_redc.js - About 1 hr to fix

    Function inv has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        inv(aRmodN) {
            // The modular inverse
            // Compute (aR mod N)^-1 using Euclidean algo
            const ai = n_trim_positive(aRmodN, 0, this.k);
    
    
    Severity: Minor
    Found in src/Montgomery.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          sub(aRmodN, bRmodN) {
              const aRpbRmodN = n_alloc(this.k);
              n_copy(aRmodN, 0, this.k, aRpbRmodN, 0);
              _isub(this.b, this.N, aRpbRmodN, bRmodN);
              return aRpbRmodN;
      Severity: Major
      Found in src/Montgomery.js and 1 other location - About 1 hr to fix
      src/Montgomery.js on lines 76..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          add(aRmodN, bRmodN) {
              const aRpbRmodN = n_alloc(this.k);
              n_copy(aRmodN, 0, this.k, aRpbRmodN, 0);
              _iadd(this.b, this.N, aRpbRmodN, bRmodN);
              return aRpbRmodN;
      Severity: Major
      Found in src/Montgomery.js and 1 other location - About 1 hr to fix
      src/Montgomery.js on lines 83..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _montgomery has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function _montgomery(b, N) {
          assert(N.length > 0);
          assert(N[0] !== 0);
      
          const k = N.length;
      Severity: Minor
      Found in src/_montgomery.js - About 1 hr to fix

        Function _mul has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export default function _mul(r, N, M, a, b, c) {
        Severity: Minor
        Found in src/_mul.js - About 45 mins to fix

          Function pown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              pown(aRmodN, x) {
                  // Modular
                  // exponentiation can be done using exponentiation by squaring by initializing the
                  // initial product to the Montgomery representation of 1, that is, to R mod N, and
                  // by replacing the multiply and square steps by Montgomery multiplies.
          Severity: Minor
          Found in src/Montgomery.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language