Sign upLogin

aureooms/js-oro

View on GitHub
Star

Showing 13 of 13 total issues

Function base has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

var base = function(A, m, n) {
    var i, j, g, f, swap, Ai, Aij, Ah, Af, Afj;


    l : for (j = 0; j < m; ++j) {
Severity: Minor
Found in js/src/simplex/base.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function simplex has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

var simplex = function(A, m, n) {
    var i, j, Am, Ah, Ahbo, Af, Afj, no, na, bo, ba, Ambo, k;

    Am = A[m];
Severity: Minor
Found in js/src/simplex/simplex.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                for (++f; f <= m; ++f) {

                    Af  = A[f];
                    Afj = Af[j];
Severity: Major
Found in js/src/simplex/base.js and 3 other locations - About 3 hrs to fix
js/src/simplex/base.js on lines 59..69
js/src/simplex/simplex.js on lines 45..55
js/src/simplex/simplex.js on lines 57..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        for (_i = 0; _i < no; ++_i) {

            Af  = A[_i];
            Afj = Af[bo];
Severity: Major
Found in js/src/simplex/simplex.js and 3 other locations - About 3 hrs to fix
js/src/simplex/base.js on lines 59..69
js/src/simplex/base.js on lines 73..83
js/src/simplex/simplex.js on lines 57..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        for (++_i; _i <= m; ++_i) {

            Af  = A[_i];
            Afj = Af[bo];
Severity: Major
Found in js/src/simplex/simplex.js and 3 other locations - About 3 hrs to fix
js/src/simplex/base.js on lines 59..69
js/src/simplex/base.js on lines 73..83
js/src/simplex/simplex.js on lines 45..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                for (f = 0; f < j; ++f) {

                    Af  = A[f];
                    Afj = Af[j];
Severity: Major
Found in js/src/simplex/base.js and 3 other locations - About 3 hrs to fix
js/src/simplex/base.js on lines 73..83
js/src/simplex/simplex.js on lines 45..55
js/src/simplex/simplex.js on lines 57..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function normalize_t has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

var normalize_t = function(fn){

    var normalize = function(A, m, n) {
        var swap, i, j, Ai, Ak, Am, k = n - 1;
Severity: Minor
Found in js/src/simplex/normalize.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function simplex has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var simplex = function(A, m, n) {
    var i, j, Am, Ah, Ahbo, Af, Afj, no, na, bo, ba, Ambo, k;

    Am = A[m];
Severity: Minor
Found in js/src/simplex/simplex.js - About 1 hr to fix

    Function base has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var base = function(A, m, n) {
    var i, j, g, f, swap, Ai, Aij, Ah, Af, Afj;


    l : for (j = 0; j < m; ++j) {
    Severity: Minor
    Found in js/src/simplex/base.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          for (  ++g; g <= n; ++g) Af[g] -= Afj * Ah[g];
      Severity: Major
      Found in js/src/simplex/base.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for (g = 0; g  < j; ++g) Af[g] -= Afj * Ah[g];
        Severity: Major
        Found in js/src/simplex/base.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              for (  ++g; g <= n; ++g) Af[g] -= Afj * Ah[g];
          Severity: Major
          Found in js/src/simplex/base.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for (g = 0; g  < j; ++g) Af[g] -= Afj * Ah[g];
            Severity: Major
            Found in js/src/simplex/base.js - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language