Sign upLogin

aureooms/js-rational-field

View on GitHub
Star

Showing 13 of 13 total issues

Function _make_rational_class has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function _make_rational_class(domain, default_display_base) {
    const {
        add,
        sub,
        mul,
Severity: Major
Found in src/_make_rational_class.js - About 4 hrs to fix

    Function from has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        from(n, d = undefined, base = undefined) {
            // Always returns a rational object.
            const Element = this.element;
            if (n.constructor.prototype === Array.prototype) {
                base = d;
    Severity: Minor
    Found in src/RationalField.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (n.match('[\\.\\|]') !== null) {
                    if (base !== undefined)
                        throw new ValueError(
                            'RationalField#from: Third parameter makes no sense with fixed point input.',
                        );
    Severity: Major
    Found in src/RationalField.js and 1 other location - About 3 hrs to fix
    src/RationalField.js on lines 33..42

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (n.match('/') !== null) {
                    if (base !== undefined)
                        throw new ValueError(
                            'RationalField#from: Third parameter makes no sense with fraction input.',
                        );
    Severity: Major
    Found in src/RationalField.js and 1 other location - About 3 hrs to fix
    src/RationalField.js on lines 22..31

    domain has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    const domain = {
        name: 'ZZ',
        add: (a, b) => a.add(b),
        sub: (a, b) => a.sub(b),
        mul: (a, b) => a.mul(b),
    Severity: Minor
    Found in src/QQ.js - About 2 hrs to fix

      Function from has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          from(n, d = undefined, base = undefined) {
              // Always returns a rational object.
              const Element = this.element;
              if (n.constructor.prototype === Array.prototype) {
                  base = d;
      Severity: Major
      Found in src/RationalField.js - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                add(other) {
                    const [a, b] = add(this.n, this.d, other.n, other.d);
                    const [c, d] = simplify(a, b);
                    return new Rational(c, d);
                }
        Severity: Major
        Found in src/_make_rational_class.js and 2 other locations - About 1 hr to fix
        src/_make_rational_class.js on lines 32..36
        src/_make_rational_class.js on lines 38..42

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                mul(other) {
                    const [a, b] = mul(this.n, this.d, other.n, other.d);
                    const [c, d] = simplify(a, b);
                    return new Rational(c, d);
                }
        Severity: Major
        Found in src/_make_rational_class.js and 2 other locations - About 1 hr to fix
        src/_make_rational_class.js on lines 26..30
        src/_make_rational_class.js on lines 32..36

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                sub(other) {
                    const [a, b] = sub(this.n, this.d, other.n, other.d);
                    const [c, d] = simplify(a, b);
                    return new Rational(c, d);
                }
        Severity: Major
        Found in src/_make_rational_class.js and 2 other locations - About 1 hr to fix
        src/_make_rational_class.js on lines 26..30
        src/_make_rational_class.js on lines 38..42

        Function _make_methods has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function _make_methods(domain) {
            const primefactors = new Map();
            const factorize = __factorize__($2, iadd1, eq0, gt1, divmod);
            const ufactors = (n) => {
                if (!primefactors.has(n)) primefactors.set(n, new Set(factorize(n)));
        Severity: Minor
        Found in src/_make_methods.js - About 1 hr to fix

          Function _make_rational_class has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          export default function _make_rational_class(domain, default_display_base) {
              const {
                  add,
                  sub,
                  mul,
          Severity: Minor
          Found in src/_make_rational_class.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              return {
                  add,
                  sub,
                  mul,
                  div,
          Severity: Major
          Found in src/_make_methods.js and 1 other location - About 1 hr to fix
          src/_make_rational_class.js on lines 6..18

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const {
                  add,
                  sub,
                  mul,
                  div,
          Severity: Major
          Found in src/_make_rational_class.js and 1 other location - About 1 hr to fix
          src/_make_methods.js on lines 46..58
          Severity
          Category
          Status
          Source
          Language