Sign upLogin

aureooms/js-tokenizer

View on GitHub
Star

Showing 9 of 9 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ( token.item === esc ) {

            ++i ;

            if ( i === len ) {
Severity: Major
Found in js/src/unescape.js and 1 other location - About 4 hrs to fix
js/src/regexp.js on lines 29..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if ( token.item === esc ) {

                ++i ;

                if ( i === len ) {
Severity: Major
Found in js/src/regexp.js and 1 other location - About 4 hrs to fix
js/src/unescape.js on lines 20..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function regexp has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

var regexp = function ( esc , raw , umap , emap , tokens , out ) {

    var i , len , token ;

    i = 0 ;
Severity: Minor
Found in js/src/regexp.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function regexp has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var regexp = function ( esc , raw , umap , emap , tokens , out ) {

    var i , len , token ;

    i = 0 ;
Severity: Minor
Found in js/src/regexp.js - About 1 hr to fix

    Function unescape has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    var unescape = function ( esc , raw , umap , emap , tokens , out ) {

    var i , len , token ;

    for ( i = 0 , len = tokens.length ; i < len ; ++i ) {
    Severity: Minor
    Found in js/src/unescape.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function longest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var longest = function ( empty , tokens , out ) {

    var i , j , len , node , next , val ;

    node = empty ;
    Severity: Minor
    Found in js/src/longest.js - About 1 hr to fix

      Function regexp has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      var regexp = function ( esc , raw , umap , emap , tokens , out ) {
      Severity: Minor
      Found in js/src/regexp.js - About 45 mins to fix

        Function unescape has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        var unescape = function ( esc , raw , umap , emap , tokens , out ) {
        Severity: Minor
        Found in js/src/unescape.js - About 45 mins to fix

          Function longest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          var longest = function ( empty , tokens , out ) {

    var i , j , len , node , next , val ;

    node = empty ;
          Severity: Minor
          Found in js/src/longest.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language