Sign upLogin

aureooms/rejuvenate

View on GitHub
Star

Showing 178 of 178 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    await update({
        read: readPkg,
        write: writePkg,
        edit(pkgjson) {
            pkgjson.scripts.travis = newScriptDefinition;
Severity: Minor
Found in src/transforms/travis:define-custom-script.js and 1 other location - About 35 mins to fix
src/transforms/release:customize-commit-message.js on lines 26..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function updateScripts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function updateScripts({scripts}) {
    return {
        async postcondition({readPkg, assert}) {
            const pkgjson = await readPkg();
            for (const [script, {newDefinition}] of Object.entries(scripts)) {
Severity: Minor
Found in src/recipes/update-scripts-definition.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function replaceOne has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

async function replaceOne(operations, path, {lines, write, method}) {
    const buffer = [];
    let changed = false;
    for await (const line of lines(path)) {
        const replacedLine = reduce(method, operations, line);
Severity: Minor
Found in src/lib/lines/replace.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export default async function find(patterns, paths, options) {
    for await (const path of paths) {
        if (await findOne(patterns, path, options)) return true;
    }
Severity: Minor
Found in src/lib/text/find.js and 1 other location - About 35 mins to fix
src/lib/lines/find.js on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export default async function find(patterns, paths, options) {
    for await (const path of paths) {
        if (await findOne(patterns, path, options)) return true;
    }
Severity: Minor
Found in src/lib/lines/find.js and 1 other location - About 35 mins to fix
src/lib/text/find.js on lines 44..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return (
        object.name === 'testlink' &&
        property.name === 'href' &&
        operator === '=' &&
        right.value !== newValue(right.value)
Severity: Major
Found in src/transforms/docs:use-codecov-as-test-link.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return na < nb ? -1 : 1;
    Severity: Major
    Found in src/lib/order.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return true;
      Severity: Major
      Found in src/transforms/codemod:use-esm-import-syntax.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in src/transforms/ava:test-build.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return (
        is(callee, n.MemberExpression) &&
        callee.object.name === 'document' &&
        callee.property.name === 'querySelectorAll'
    );
          Severity: Major
          Found in src/transforms/codemod:doc-scripts-header-replace-querySelectorAll.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in src/transforms/codemod:use-esm-import-syntax.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  if (!is(property, n.Identifier)) return false;
              Severity: Major
              Found in src/transforms/docs:use-codecov-as-test-link.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return absolute === SOURCE_MODULE;
                Severity: Major
                Found in src/transforms/ava:test-build.js - About 30 mins to fix

                  Function chcwd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export default function chcwd({
    cwd,
    offline,
    install: installFlag,
    test: testFlag,
                  Severity: Minor
                  Found in src/util/chcwd.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export async function apply({readPkg, writePkg, upgrade, fixConfig, install}) {
    // Update package.json
    await update({
        read: readPkg,
        write: writePkg,
                  Severity: Minor
                  Found in src/transforms/deps:replace-scoped-babel-polyfill-with-regenerator-runtime.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const format = (pkgjson) => {
    const babel = pkgjson.babel;
    if (babel) {
        const env = babel.env;
        if (env) {
                  Severity: Minor
                  Found in src/lib/babel.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  const filter = (node, {is, n}) => {
    if (!is(node, n.AssignmentExpression)) return false;
    const {operator, left, right} = node;
    if (!is(left, n.MemberExpression)) return false;
    if (!is(right, n.Literal)) return false;
                  Severity: Minor
                  Found in src/transforms/docs:use-codecov-as-test-link.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export async function apply({
    read,
    write,
    readPkg,
    writePkg,
                  Severity: Minor
                  Found in src/transforms/replace-babel-preset-latest-by-scoped-babel-preset-env.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language