austinheap/wordpress-security-txt

View on GitHub

Showing 20 of 20 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function radios($args)
    {
        $defaults['class'] = $defaults['label'] = $defaults['description'] = '';
        $defaults['name']  = $this->plugin_name . '-options[' . $args['id'] . ']';
        $defaults['value'] = 0;
Severity: Major
Found in trunk/admin/class-wordpress-security-txt-builder.php and 1 other location - About 4 hrs to fix
trunk/admin/class-wordpress-security-txt-builder.php on lines 77..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function checkbox($args)
    {
        $defaults['class'] = $defaults['description'] = $defaults['label'] = '';
        $defaults['name']  = $this->plugin_name . '-options[' . $args['id'] . ']';
        $defaults['value'] = 0;
Severity: Major
Found in trunk/admin/class-wordpress-security-txt-builder.php and 1 other location - About 4 hrs to fix
trunk/admin/class-wordpress-security-txt-builder.php on lines 126..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

WordPress_Security_Txt_Admin has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class WordPress_Security_Txt_Admin
{
    /**
     * The ID of this plugin.
     *
Severity: Minor
Found in trunk/admin/class-wordpress-security-txt-admin.php - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function debug()
        {
            add_settings_field(
                'debug',
                apply_filters($this->plugin_name . 'label-debug', esc_html__('Debug', $this->plugin_name)),
    Severity: Major
    Found in trunk/admin/class-wordpress-security-txt-field.php and 3 other locations - About 1 hr to fix
    trunk/admin/class-wordpress-security-txt-field.php on lines 313..328
    trunk/admin/class-wordpress-security-txt-field.php on lines 335..350
    trunk/admin/class-wordpress-security-txt-field.php on lines 357..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function cache()
        {
            add_settings_field(
                'cache',
                apply_filters($this->plugin_name . 'label-cache', esc_html__('Cache', $this->plugin_name)),
    Severity: Major
    Found in trunk/admin/class-wordpress-security-txt-field.php and 3 other locations - About 1 hr to fix
    trunk/admin/class-wordpress-security-txt-field.php on lines 335..350
    trunk/admin/class-wordpress-security-txt-field.php on lines 357..372
    trunk/admin/class-wordpress-security-txt-field.php on lines 379..394

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function statistics()
        {
            add_settings_field(
                'statistics',
                apply_filters($this->plugin_name . 'label-statistics', esc_html__('Statistics', $this->plugin_name)),
    Severity: Major
    Found in trunk/admin/class-wordpress-security-txt-field.php and 3 other locations - About 1 hr to fix
    trunk/admin/class-wordpress-security-txt-field.php on lines 313..328
    trunk/admin/class-wordpress-security-txt-field.php on lines 335..350
    trunk/admin/class-wordpress-security-txt-field.php on lines 379..394

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function credits()
        {
            add_settings_field(
                'credits',
                apply_filters($this->plugin_name . 'label-credits', esc_html__('Credits', $this->plugin_name)),
    Severity: Major
    Found in trunk/admin/class-wordpress-security-txt-field.php and 3 other locations - About 1 hr to fix
    trunk/admin/class-wordpress-security-txt-field.php on lines 313..328
    trunk/admin/class-wordpress-security-txt-field.php on lines 357..372
    trunk/admin/class-wordpress-security-txt-field.php on lines 379..394

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function validate_repeater has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function validate_repeater($input, &$valid)
        {
            $clean = [];
    
            foreach ($option[2] as $field) {
    Severity: Minor
    Found in trunk/admin/class-wordpress-security-txt-admin.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function clean has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function clean()
        {
            $sanitized = '';
    
            if (in_array($this->type, ['color', 'radio', 'select'], true)) {
    Severity: Minor
    Found in trunk/admin/class-wordpress-security-txt-sanitizer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (jQuery(this)[0].checked) {
                    jQuery('.hide-when-disabled').closest('tr').fadeIn();
                    jQuery('p.hide-when-disabled, div.hide-when-disabled').fadeIn().prev().fadeIn();
                } else {
    Severity: Minor
    Found in trunk/admin/js/wordpress-security-txt-admin.js and 1 other location - About 55 mins to fix
    trunk/admin/js/wordpress-security-txt-admin.js on lines 15..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                } else {
                    jQuery('.hide-when-disabled').closest('tr').fadeOut();
                    jQuery('p.hide-when-disabled, div.hide-when-disabled').fadeOut().prev().fadeOut();
                }
    Severity: Minor
    Found in trunk/admin/js/wordpress-security-txt-admin.js and 1 other location - About 55 mins to fix
    trunk/admin/js/wordpress-security-txt-admin.js on lines 12..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method add has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private function add($hooks, $hook, $component, $callback, $priority, $accepted_args)
    Severity: Minor
    Found in trunk/includes/class-wordpress-security-txt-loader.php - About 45 mins to fix

      Function render_security_txt has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function render_security_txt()
          {
              $output = $this->get_security_txt_cache();
      
              if (empty($output)) {
      Severity: Minor
      Found in trunk/public/class-wordpress-security-txt-public.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              jQuery('input[name="wordpress-security-txt-options[contact]"]').on('click keyup keypress blur change focus', function () {
                  window.WORDPRESS_SECURITY_TXT_VALIDATORS.apply(jQuery(this), 'contact');
              }).trigger('click');
      Severity: Minor
      Found in trunk/admin/js/wordpress-security-txt-admin.js and 2 other locations - About 40 mins to fix
      trunk/admin/js/wordpress-security-txt-admin.js on lines 80..82
      trunk/admin/js/wordpress-security-txt-admin.js on lines 84..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              jQuery('textarea[name="wordpress-security-txt-options[encryption]"]').on('click keyup keypress blur change focus', function () {
                  window.WORDPRESS_SECURITY_TXT_VALIDATORS.apply(jQuery(this), 'encryption');
              }).trigger('click');
      Severity: Minor
      Found in trunk/admin/js/wordpress-security-txt-admin.js and 2 other locations - About 40 mins to fix
      trunk/admin/js/wordpress-security-txt-admin.js on lines 76..78
      trunk/admin/js/wordpress-security-txt-admin.js on lines 84..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              jQuery('input[name="wordpress-security-txt-options[acknowledgement]"]').on('click keyup keypress blur change focus', function () {
                  window.WORDPRESS_SECURITY_TXT_VALIDATORS.apply(jQuery(this), 'acknowledgement');
              }).trigger('click');
      Severity: Minor
      Found in trunk/admin/js/wordpress-security-txt-admin.js and 2 other locations - About 40 mins to fix
      trunk/admin/js/wordpress-security-txt-admin.js on lines 76..78
      trunk/admin/js/wordpress-security-txt-admin.js on lines 80..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method add_filter has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function add_filter($hook, $component, $callback, $priority = 10, $accepted_args = 1)
      Severity: Minor
      Found in trunk/includes/class-wordpress-security-txt-loader.php - About 35 mins to fix

        Method add_action has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function add_action($hook, $component, $callback, $priority = 10, $accepted_args = 1)
        Severity: Minor
        Found in trunk/includes/class-wordpress-security-txt-loader.php - About 35 mins to fix

          Function apply_routes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function apply_routes($uri)
              {
                  $routes = [
                      '/security.txt'             => ['method' => 'redirect', 'document' => 'security.txt'],
                      '/.well-known/security.txt' => ['method' => 'show', 'document' => 'security.txt'],
          Severity: Minor
          Found in trunk/public/class-wordpress-security-txt-public.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_security_txt_cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function get_security_txt_cache()
              {
                  $data = null;
          
                  if (isset($this->options['cache']) && $this->options['cache']) {
          Severity: Minor
          Found in trunk/public/class-wordpress-security-txt-public.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language