Sign upLogin

autolab/Autolab

View on GitHub
Star
app/controllers/assessment/autograde.rb

Summary

Maintainability
D
1 day
Test Coverage

Method sendJob_AddHTMLMessages has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sendJob_AddHTMLMessages(course, assessment, submissions)
    # Check for nil first, since students should know about this
    flash[:error] = "Submission could not be autograded due to an error in creation" && return if submissions.blank?

    begin
Severity: Minor
Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

    Method sendJob_AddHTMLMessages has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def sendJob_AddHTMLMessages(course, assessment, submissions)
    # Check for nil first, since students should know about this
    flash[:error] = "Submission could not be autograded due to an error in creation" && return if submissions.blank?

    begin
    Severity: Minor
    Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method autograde_done has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def autograde_done
    @assessment = @course.assessments.find_by(name: params[:name])
    head(:no_content) && return unless @assessment && @assessment.has_autograder?
    ASSESSMENT_LOGGER.setAssessment(@assessment)
    Severity: Minor
    Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method autograde_done has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def autograde_done
    @assessment = @course.assessments.find_by(name: params[:name])
    head(:no_content) && return unless @assessment && @assessment.has_autograder?
    ASSESSMENT_LOGGER.setAssessment(@assessment)
    Severity: Minor
    Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

      Method regradeAll has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def regradeAll
    # Grab all of the submissions for this assessment
    @submissions = @assessment.submissions.where(special_type: Submission::NORMAL)
                   .order("version DESC")
      Severity: Minor
      Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

        Method regradeBatch has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def regradeBatch
    submission_ids = params[:submission_ids]

    # Now regrade only the most recent submissions. Keep track of
    # any handins that fail.
        Severity: Minor
        Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

          Method regradeAll has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def regradeAll
    # Grab all of the submissions for this assessment
    @submissions = @assessment.submissions.where(special_type: Submission::NORMAL)
                   .order("version DESC")
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method regradeBatch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def regradeBatch
    submission_ids = params[:submission_ids]

    # Now regrade only the most recent submissions. Keep track of
    # any handins that fail.
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if failure_jobs > 0
      flash[:error] = "Warning: Could not regrade #{ActionController::Base.helpers.pluralize(failure_jobs, "submission")}:<br>"
      failed_list.each do |failure|
        if failure[:error].error_code == :nil_submission
          flash[:error] += "Unrecognized submission ID<br>"
          Severity: Major
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 1 hr to fix
          app/controllers/assessment/autograde.rb on lines 153..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if failure_jobs > 0
      flash[:error] = "Warning: Could not regrade #{ActionController::Base.helpers.pluralize(failure_jobs, "submission")}:<br>"
      failed_list.each do |failure|
        if failure[:error].error_code == :nil_submission
          flash[:error] += "Unrecognized submission ID<br>"
          Severity: Major
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 1 hr to fix
          app/controllers/assessment/autograde.rb on lines 106..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
      failed_list = sendJob_batch(@course, @assessment, submissions, @cud)
    rescue AssessmentAutogradeCore::AutogradeError => e
      if e.error_code == :missing_autograding_props
        # no autograding properties for this assessment
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 25 mins to fix
          app/controllers/assessment/autograde.rb on lines 142..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 30.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
      failed_list = sendJob_batch(@course, @assessment, last_submissions, @cud)
    rescue AssessmentAutogradeCore::AutogradeError => e
      if e.error_code == :missing_autograding_props
        # no autograding properties for this assessment
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 25 mins to fix
          app/controllers/assessment/autograde.rb on lines 95..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 30.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if success_jobs > 0
      link = "<a href=\"#{url_for(controller: 'jobs')}\">#{ActionController::Base.helpers.pluralize(success_jobs, "submission")}</a>"
      flash[:success] = ("Regrading #{link}")
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 20 mins to fix
          app/controllers/assessment/autograde.rb on lines 165..167

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if success_jobs > 0
      link = "<a href=\"#{url_for(controller: 'jobs')}\">#{ActionController::Base.helpers.pluralize(success_jobs, "student")}</a>"
      flash[:success] = ("Regrading the most recent submissions from #{link}")
          Severity: Minor
          Found in app/controllers/assessment/autograde.rb and 1 other location - About 20 mins to fix
          app/controllers/assessment/autograde.rb on lines 118..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status