Sign upLogin

autolab/Autolab

View on GitHub
Star
app/helpers/assessment_handin_core.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method validateHandinForGroups has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def validateHandinForGroups
    return :valid unless @assessment.has_groups?

    submitter_aud = @assessment.aud_for(@cud.id)
    return :valid unless submitter_aud
Severity: Minor
Found in app/helpers/assessment_handin_core.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saveHandin has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def saveHandin(sub, app_id = nil)
    unless @assessment.has_groups?
      submission = @assessment.submissions.create!(course_user_datum_id: @cud.id,
                                                  submitter_ip: request.remote_ip,
                                                  submitted_by_app_id: app_id)
Severity: Minor
Found in app/helpers/assessment_handin_core.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

          return :fail_type_check
    Severity: Major
    Found in app/helpers/assessment_handin_core.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return :valid
      Severity: Major
      Found in app/helpers/assessment_handin_core.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return :group_submission_limit_exceeded
        Severity: Major
        Found in app/helpers/assessment_handin_core.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return :valid
          Severity: Major
          Found in app/helpers/assessment_handin_core.rb - About 30 mins to fix

            Method validateHandin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def validateHandin(size, content_type, filename)
    # Make sure that handins are allowed
    if @assessment.disable_handins?
      return :handin_disabled
    end
            Severity: Minor
            Found in app/helpers/assessment_handin_core.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status