Sign upLogin

autonomouslogic/dynamo-mapper

View on GitHub
Star
src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java

Summary

Maintainability
D
2 days
Test Coverage

File PermutationTester.java has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.autonomouslogic.dynamomapper;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
Severity: Minor
Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 3 hrs to fix

    Method testDelete has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SneakyThrows
    private MappedDeleteItemResponse<IntegrationTestObject> testDelete(IntegrationTestObject obj) {
        var key = encoder.encodeKeyValue(obj);
        switch (methodType) {
            case REQUEST:
    Severity: Minor
    Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 1 hr to fix

      Method testGet has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @SneakyThrows
    private MappedGetItemResponse<IntegrationTestObject> testGet(IntegrationTestObject obj) {
        var key = encoder.encodeKeyValue(obj);
        switch (methodType) {
            case REQUEST:
      Severity: Minor
      Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 1 hr to fix

        Method testUpdate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @SneakyThrows
    private MappedUpdateItemResponse<IntegrationTestObject> testUpdate(IntegrationTestObject obj) {
        var key = encoder.encodeKeyValue(obj);
        var updates = encoder.encodeUpdates(obj);
        switch (methodType) {
        Severity: Minor
        Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 1 hr to fix

          Method testPut has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @SneakyThrows
    private MappedPutItemResponse<IntegrationTestObject> testPut(IntegrationTestObject obj) {
        var item = encoder.encode(obj);
        switch (methodType) {
            case REQUEST:
          Severity: Minor
          Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 1 hr to fix

            Method testGet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                @SneakyThrows
    private MappedGetItemResponse<IntegrationTestObject> testGet(IntegrationTestObject obj) {
        var key = encoder.encodeKeyValue(obj);
        switch (methodType) {
            case REQUEST:
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method testDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                @SneakyThrows
    private MappedDeleteItemResponse<IntegrationTestObject> testDelete(IntegrationTestObject obj) {
        var key = encoder.encodeKeyValue(obj);
        switch (methodType) {
            case REQUEST:
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method runTest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public void runTest() {
        // Get
        var emptyGetResponse = testGet(obj);
        assertNull(emptyGetResponse.item());
        // Put.
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        case REQUEST:
                switch (callMethod) {
                    case STRAIGHT:
                        return getItemRequestStraight.apply(
                                GetItemRequest.builder().key(key).build(), IntegrationTestObject.class);
            Severity: Major
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 1 hr to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 221..234

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        case REQUEST:
                switch (callMethod) {
                    case STRAIGHT:
                        return putItemRequestStraight.apply(
                                PutItemRequest.builder().item(item).build(), IntegrationTestObject.class);
            Severity: Major
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 1 hr to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 170..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            builder -> {
                                    var req = builder.build();
                                    assertEquals("integration-test-table", req.tableName());
                                    assertEquals(key, req.key());
                                    builder.returnValues(ReturnValue.ALL_OLD);
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 35 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 335..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 44.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                    return deleteItemKeyObjectConsumer.apply(obj, builder -> {
                            var req = builder.build();
                            assertEquals("integration-test-table", req.tableName());
                            assertEquals(key, req.key());
                            builder.returnValues(ReturnValue.ALL_OLD);
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 35 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 322..327

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 44.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (methodType == MethodType.REQUEST || callMethod == CallMethod.CONSUMER) {
            assertEquals(obj2, deleteResponse.item());
        } else {
            assertNull(updateResponse.item());
        }
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 30 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 149..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                    return getItemKeyObjectConsumer.apply(obj, builder -> {
                            var req = builder.build();
                            assertEquals("integration-test-table", req.tableName());
                            assertEquals(
                                    obj.partitionKey(),
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 30 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 191..197

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (methodType == MethodType.REQUEST || callMethod == CallMethod.CONSUMER) {
            assertEquals(obj2, updateResponse.item());
        } else {
            assertNull(updateResponse.item());
        }
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 30 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 156..160

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            builder -> {
                                    var req = builder.build();
                                    assertEquals("integration-test-table", req.tableName());
                                    assertEquals(
                                            obj.partitionKey(),
            Severity: Minor
            Found in src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java and 1 other location - About 30 mins to fix
            src/integrationTest/java/com/autonomouslogic/dynamomapper/PermutationTester.java on lines 205..211

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status