Showing 255 of 255 total issues
Use each_value
instead of each
. Open
Open
row.each do |_k, v|
- Read upRead up
- Exclude checks
This cop checks for uses of each_key
and each_value
Hash methods.
Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.
Example:
# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }
# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }
TODO found Open
Open
# TODO: - do we really need to pass in the doc context when parent nodes already has it ?
- Exclude checks
TODO found Open
Open
# TODO: - read in from configration
- Exclude checks
TODO found Open
Open
# TODO: - prepare_data_flow_schema here in middle of export, plus reaching through nodes to klass, does not smell right
- Exclude checks
TODO found Open
Open
# TODO: - this is instance methods .. what about class methods ?
- Exclude checks
TODO found Open
Open
# TODO: fix doc context so it can be created 'empty' i.e without AR klass, and always has empty headers
- Exclude checks
TODO found Open
Open
# TODO: - make more robust - currently end on first empty column
- Exclude checks
TODO found Open
Open
# TODO: - check out regexp to do this work better plus Inflections ??
- Exclude checks
TODO found Open
Open
# TODO: - now we know this column is an enum set operator type to :enum to save this check in future
- Exclude checks
TODO found Open
Open
# TODO: - enable clients to register their own transformation methods and call them here
- Exclude checks
TODO found Open
Open
# TODO: - layout with heading is verbose for no benefit - defunct, simply node.source, node.presentation
- Exclude checks
TODO found Open
Open
# TODO: - better ways ?? - see transcoding and String#encode
- Exclude checks
TODO found Open
Open
# TODO: some way to define if this is a fatal error or not ?
- Exclude checks
TODO found Open
Open
# TODO: - can we abstract out what a 'parsed file' is - headers plus value of each node
- Exclude checks
TODO found Open
Open
# TODO: make this more robust ? e.g what about when using active record but not in Rails app, Sinatra etc
- Exclude checks
TODO found Open
Open
# TODO - add another ruby parse layer to strip these out completely
- Exclude checks
TODO found Open
Open
# TODO: what is c ? a list or hash ?
- Exclude checks
TODO found Open
Open
# (TODO - write spec to process .xls with a huge number of rows)
- Exclude checks
TODO found Open
Open
# TODO: - how does this get inserted - bind headers ?? ignore if no index
- Exclude checks
TODO found Open
Open
# TODO: - use delegators
- Exclude checks