Sign upLogin

autotelik/datashift

View on GitHub
Star
lib/datashift/applications/hssf_row_extensions.rb

Summary

Maintainability
A
0 mins
Test Coverage

TODO found
Open

        # TODO
Severity: Minor
Found in lib/datashift/applications/hssf_row_extensions.rb by fixme

Move getCell(ref.getCol) out of the conditional.
Open

            getCell(ref.getCol) # || java_send(:createCell, column)
Severity: Minor
Found in lib/datashift/applications/hssf_row_extensions.rb by rubocop

This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

Example:

# bad
if condition
  do_x
  do_z
else
  do_y
  do_z
end

# good
if condition
  do_x
else
  do_y
end
do_z

# bad
if condition
  do_z
  do_x
else
  do_z
  do_y
end

# good
do_z
if condition
  do_x
else
  do_y
end

# bad
case foo
when 1
  do_x
when 2
  do_x
else
  do_x
end

# good
case foo
when 1
  do_x
  do_y
when 2
  # nothing
else
  do_x
  do_z
end

Move getCell(ref.getCol) out of the conditional.
Open

            getCell(ref.getCol) # || createCell(column, poi_cell_type(value))
Severity: Minor
Found in lib/datashift/applications/hssf_row_extensions.rb by rubocop

This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

Example:

# bad
if condition
  do_x
  do_z
else
  do_y
  do_z
end

# good
if condition
  do_x
else
  do_y
end
do_z

# bad
if condition
  do_z
  do_x
else
  do_z
  do_y
end

# good
do_z
if condition
  do_x
else
  do_y
end

# bad
case foo
when 1
  do_x
when 2
  do_x
else
  do_x
end

# good
case foo
when 1
  do_x
  do_y
when 2
  # nothing
else
  do_x
  do_z
end

There are no issues that match your filters.

Category
Status