Sign upLogin

autotelik/datashift

View on GitHub
Star
lib/datashift/exporters/csv_exporter.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method export has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def export(file_name, export_records, options = {})

      @file_name = file_name

      records = [*export_records]
Severity: Minor
Found in lib/datashift/exporters/csv_exporter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method export_with_associations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def export_with_associations(file_name, klass, records, options = {})

      state = DataShift::Configuration.call.with

      DataShift::Configuration.call.with = :all
Severity: Minor
Found in lib/datashift/exporters/csv_exporter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not place comments on the same line as the end keyword.
Open

    end # end write file
Severity: Minor
Found in lib/datashift/exporters/csv_exporter.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

There are no issues that match your filters.

Category
Status