Sign upLogin

autotelik/datashift

View on GitHub
Star
lib/datashift/loaders/csv_loader.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method perform_load has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def perform_load( _options = {} )
      require 'csv'

      raise "Cannot load - failed to create a #{klass}" unless load_object
Severity: Minor
Found in lib/datashift/loaders/csv_loader.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for perform_load is too high. [76.12/60]
Open

    def perform_load( _options = {} )
      require 'csv'

      raise "Cannot load - failed to create a #{klass}" unless load_object
Severity: Minor
Found in lib/datashift/loaders/csv_loader.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method perform_load has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def perform_load( _options = {} )
      require 'csv'

      raise "Cannot load - failed to create a #{klass}" unless load_object
Severity: Minor
Found in lib/datashift/loaders/csv_loader.rb - About 1 hr to fix

    Block has too many lines. [30/25]
    Open

            load_object_class.transaction do
          logger.info "Processing #{parsed_file.size} rows"

          parsed_file.each_with_index do |row, i|
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    TODO found
    Open

          # TODO: - can we abstract out what a 'parsed file' is - headers plus value of each node
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by fixme

    Do not place comments on the same line as the end keyword.
    Open

                end # end of each column(node)
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

    Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

    Example:

    # bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

    Do not place comments on the same line as the end keyword.
    Open

            end # TRANSACTION N.B ActiveRecord::Rollback does not propagate outside of the containing transaction block
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

    Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

    Example:

    # bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

    Shadowing outer local variable - i.
    Open

                @binder.bindings.each_with_index do |method_binding, i|
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop looks for use of the same name as outer local variables for block arguments or block local variables. This is a mimic of the warning "shadowing outer local variable - foo" from ruby -cw.

    Example:

    # bad

def some_method
  foo = 1

  2.times do |foo| # shadowing outer `foo`
    do_something(foo)
  end
end

    Example:

    # good

def some_method
  foo = 1

  2.times do |bar|
    do_something(bar)
  end
end

    Do not place comments on the same line as the end keyword.
    Open

              end # all rows processed
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

    Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

    Example:

    # bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

    Use && instead of and.
    Open

                doc_context.reset and next if doc_context.errors?
    Severity: Minor
    Found in lib/datashift/loaders/csv_loader.rb by rubocop

    This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

    Example: EnforcedStyle: always (default)

    # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

    Example: EnforcedStyle: conditionals

    # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

    There are no issues that match your filters.

    Category
    Status