Sign upLogin

autotelik/datashift_journey

View on GitHub
Star
app/controllers/concerns/datashift_journey/validate_state.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method validate_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_state
      current_index = journey_plan.current_state_index

      view_state = params[:rendered_state]
Severity: Minor
Found in app/controllers/concerns/datashift_journey/validate_state.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use %i or %I for an array of symbols.
Open

      @back_button_param_list ||= [:state, :id, :action, :controller]
Severity: Minor
Found in app/controllers/concerns/datashift_journey/validate_state.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Re-enable Style/GuardClause cop with # rubocop:enable after disabling it.
Open

    # rubocop:disable  Style/GuardClause
Severity: Minor
Found in app/controllers/concerns/datashift_journey/validate_state.rb by rubocop

There are no issues that match your filters.

Category
Status