Sign upLogin

autowp/autowp

View on GitHub
Star

Showing 1,718 of 1,718 total issues

File SpecificationsService.php has 1897 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Application\Service;

use Application\ItemNameFormatter;
Severity: Major
Found in module/Application/src/Service/SpecificationsService.php - About 5 days to fix

    File ItemController.php has 1786 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Application\Controller\Api;

use Application\Controller\Plugin\Car;
    Severity: Major
    Found in module/Application/src/Controller/Api/ItemController.php - About 4 days to fix

      Function extract has a Cognitive Complexity of 199 (exceeds 5 allowed). Consider refactoring.
      Open

          public function extract($object): ?array
    {
        if (! (is_array($object) || $object instanceof ArrayAccess)) {
            return null;
        }
      Severity: Minor
      Found in module/Application/src/Hydrator/Api/PictureHydrator.php - About 4 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extract has a Cognitive Complexity of 181 (exceeds 5 allowed). Consider refactoring.
      Open

          public function extract($object): ?array
    {
        $nameData = $this->getNameData($object, $this->language);

        $isModer = false;
      Severity: Minor
      Found in module/Application/src/Hydrator/Api/ItemHydrator.php - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function indexAction has a Cognitive Complexity of 179 (exceeds 5 allowed). Consider refactoring.
      Open

          public function indexAction()
    {
        $isModer = $this->user()->enforce('global', 'moderate');

        $user = $this->user()->get();
      Severity: Minor
      Found in module/Application/src/Controller/Api/ItemController.php - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Item.php has 1348 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace Application\Model;

use Application\Module;
      Severity: Major
      Found in module/Application/src/Model/Item.php - About 3 days to fix

        Function updateAction has a Cognitive Complexity of 160 (exceeds 5 allowed). Consider refactoring.
        Open

            public function updateAction()
    {
        $user = $this->user()->get();
        if (! $user) {
            return $this->forbiddenAction();
        Severity: Minor
        Found in module/Application/src/Controller/Api/PictureController.php - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File PictureController.php has 1108 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace Application\Controller\Api;

use Application\Comments;
        Severity: Major
        Found in module/Application/src/Controller/Api/PictureController.php - About 2 days to fix

          Method extract has 531 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function extract($object): ?array
    {
        if (! (is_array($object) || $object instanceof ArrayAccess)) {
            return null;
        }
          Severity: Major
          Found in module/Application/src/Hydrator/Api/PictureHydrator.php - About 2 days to fix

            File Picture.php has 1006 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

namespace Application\Model;

use Application\Comments;
            Severity: Major
            Found in module/Application/src/Model/Picture.php - About 2 days to fix

              Method extract has 500 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function extract($object): ?array
    {
        $nameData = $this->getNameData($object, $this->language);

        $isModer = false;
              Severity: Major
              Found in module/Application/src/Hydrator/Api/ItemHydrator.php - About 2 days to fix

                Method indexAction has 472 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function indexAction()
    {
        $isModer = $this->user()->enforce('global', 'moderate');

        $user = $this->user()->get();
                Severity: Major
                Found in module/Application/src/Controller/Api/ItemController.php - About 2 days to fix

                  Function putAction has a Cognitive Complexity of 103 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function putAction()
    {
        if (! $this->user()->enforce('car', 'edit_meta')) {
            return $this->forbiddenAction();
        }
                  Severity: Minor
                  Found in module/Application/src/Controller/Api/ItemController.php - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method dataProvider has 402 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function dataProvider(): array
    {
        return [
            [
                [
                  Severity: Major
                  Found in module/Application/test/PictureNameFormatterTest.php - About 2 days to fix

                    Function getSelect has a Cognitive Complexity of 95 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getSelect(array $options): Sql\Select
    {
        $defaults = [
            'id'               => null,
            'id_exclude'       => null,
                    Severity: Minor
                    Found in module/Application/src/Model/Picture.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File ItemHydrator.php has 796 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php

namespace Application\Hydrator\Api;

use Application\Comments;
                    Severity: Major
                    Found in module/Application/src/Hydrator/Api/ItemHydrator.php - About 1 day to fix

                      File PictureHydrator.php has 766 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

namespace Application\Hydrator\Api;

use Application\Comments;
                      Severity: Major
                      Found in module/Application/src/Hydrator/Api/PictureHydrator.php - About 1 day to fix

                        Method getSelect has 350 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getSelect(array $options): Sql\Select
    {
        $defaults = [
            'id'               => null,
            'id_exclude'       => null,
                        Severity: Major
                        Found in module/Application/src/Model/Picture.php - About 1 day to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct(
        AbstractRestHydrator $hydrator,
        PictureItem $pictureItem,
        DuplicateFinder $duplicateFinder,
        UserPicture $userPicture,
                          Severity: Major
                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 1 day to fix
                          module/Application/src/Service/SpecificationsService.php on lines 128..175

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 356.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct(
        TranslatorInterface $translator,
        ItemNameFormatter $itemNameFormatter,
        Item $itemModel,
        ItemParent $itemParent,
                          Severity: Major
                          Found in module/Application/src/Service/SpecificationsService.php and 1 other location - About 1 day to fix
                          module/Application/src/Controller/Api/PictureController.php on lines 114..161

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 356.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language