Sign upLogin

autowp/external-login-service

View on GitHub
Star
src/Vk.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getData has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getData(array $options): Result
    {
        $provider = $this->getProvider();

        if (isset($options['language'])) {
Severity: Minor
Found in src/Vk.php - About 1 hr to fix

    Function getData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getData(array $options): Result
    {
        $provider = $this->getProvider();

        if (isset($options['language'])) {
    Severity: Minor
    Found in src/Vk.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method getData() has an NPath complexity of 972. The configured NPath complexity threshold is 200.
    Open

        public function getData(array $options): Result
    {
        $provider = $this->getProvider();

        if (isset($options['language'])) {
    Severity: Minor
    Found in src/Vk.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getData() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        public function getData(array $options): Result
    {
        $provider = $this->getProvider();

        if (isset($options['language'])) {
    Severity: Minor
    Found in src/Vk.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Possibly zero references to protected method \Autowp\ExternalLoginService\Vk::getFriendsAuthorizationUrl()
    Open

        protected function getFriendsAuthorizationUrl(): string
    Severity: Minor
    Found in src/Vk.php by phan

    Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string)
    Open

            $data['name'] = $firstName . ($firstName && $lastName ? ' ' : '') . $lastName;
    Severity: Minor
    Found in src/Vk.php by phan

    Possibly zero references to public method \Autowp\ExternalLoginService\Vk::getFriends()
    Open

        public function getFriends(): array
    Severity: Minor
    Found in src/Vk.php by phan

    Possibly zero references to protected method \Autowp\ExternalLoginService\Vk::createProvider()
    Open

        protected function createProvider(): VkProvider
    Severity: Minor
    Found in src/Vk.php by phan

    Call with 1 arg(s) to \Autowp\ExternalLoginService\Provider\VkProvider::__construct() which only takes 0 arg(s) defined at /code/src/Provider/VkProvider.php:10
    Open

            return new VkProvider([
    Severity: Info
    Found in src/Vk.php by phan

    Possibly zero references to public method \Autowp\ExternalLoginService\Vk::getData()
    Open

        public function getData(array $options): Result
    Severity: Minor
    Found in src/Vk.php by phan

    Possibly zero references to public method \Autowp\ExternalLoginService\Vk::getFriendsUrl()
    Open

        public function getFriendsUrl(): string
    Severity: Minor
    Found in src/Vk.php by phan

    Avoid classes with short names like Vk. Configured minimum length is 3.
    Open

    class Vk extends AbstractLeagueOAuth2
{
    protected function createProvider(): VkProvider
    {
        return new VkProvider([
    Severity: Minor
    Found in src/Vk.php by phpmd

    ShortClassName

    Since: 2.9

    Detects when classes or interfaces have a very short name.

    Example

    class Fo {

}

interface Fo {

}

    Source https://phpmd.org/rules/naming.html#shortclassname

    There are no issues that match your filters.

    Category
    Status