Sign upLogin

autowp/image

View on GitHub
Star

Showing 100 of 100 total issues

Method flush has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function flush(array $options): StorageInterface
    {
        $defaults = [
            'format' => null,
            'image'  => null,
Severity: Minor
Found in src/Storage.php - About 1 hr to fix

    Method flop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function flop(int $imageId): void
    {
        $imageRow = $this->getImageRow($imageId);

        if (! $imageRow) {
    Severity: Minor
    Found in src/Storage.php - About 1 hr to fix

      Method normalize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function normalize(int $imageId): void
    {
        $imageRow = $this->getImageRow($imageId);

        if (! $imageRow) {
      Severity: Minor
      Found in src/Storage.php - About 1 hr to fix

        Method buildImageResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function buildImageResult($imageRow): Storage\Image
    {
        $dir = $this->getDir($imageRow['dir']);
        if (! $dir) {
            throw new Storage\Exception("Dir '{$imageRow['dir']}' not defined");
        Severity: Minor
        Found in src/Storage.php - About 1 hr to fix

          Function addImageFromFile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addImageFromFile(string $file, string $dirName, array $options = []): int
    {
        $imageInfo = getimagesize($file);

        $width  = (int) $imageInfo[0];
          Severity: Minor
          Found in src/Storage.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  $id = $this->generateLockWrite(
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $s3. Configured minimum length is 3.
          Open

              private S3Client $s3;
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $e. Configured minimum length is 3.
          Open

              private function isDuplicateKeyException(Exception $e): bool
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $pi. Configured minimum length is 3.
          Open

                      $pi              = pathinfo($newPath);
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

                  $y = $info['resolution']['y'];
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $s3. Configured minimum length is 3.
          Open

                          $s3 = $this->getS3Client();
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  $id   = $this->generateLockWrite(
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $x. Configured minimum length is 3.
          Open

                  $x = $info['resolution']['x'];
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $to. Configured minimum length is 3.
          Open

                  $to   = (int) pow(10, $attempt) - 1;
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              private int $id;
          Severity: Minor
          Found in src/Storage/Image.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                          $id = (int) $this->imageTable->getLastInsertValue();
          Severity: Minor
          Found in src/Storage.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Function addImageFromImagick has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addImageFromImagick(Imagick $imagick, string $dirName, array $options = []): int
    {
        $width  = $imagick->getImageWidth();
        $height = $imagick->getImageHeight();
          Severity: Minor
          Found in src/Storage.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function changeImageName has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function changeImageName(int $imageId, array $options = []): void
    {
        $imageRow = $this->getImageRow($imageId);
        if (! $imageRow) {
            throw new Storage\Exception("Image `$imageId` not found");
          Severity: Minor
          Found in src/Storage.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class ConfigProvider has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
          Open

          class ConfigProvider
{
    public function __invoke(): array
    {
        return [
          Severity: Minor
          Found in src/ConfigProvider.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          The class Storage has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.
          Open

          class Storage implements StorageInterface
{
    private const EXTENSION_DEFAULT = 'jpg';

    private const INSERT_MAX_ATTEMPTS = 15;
          Severity: Minor
          Found in src/Storage.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          Severity
          Category
          Status
          Source
          Language