File Storage.php
has 1026 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace Autowp\Image;
Storage
has 53 functions (exceeds 20 allowed). Consider refactoring. Open
class Storage implements StorageInterface
{
private const EXTENSION_DEFAULT = 'jpg';
private const INSERT_MAX_ATTEMPTS = 15;
Method doFormatImage
has 116 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function doFormatImage(int $imageId, string $formatName): int
{
// find source image
/** @var ResultSet $resultSet */
$resultSet = $this->imageTable->select([
The class Storage has an overall complexity of 183 which is very high. The configured complexity threshold is 50. Open
class Storage implements StorageInterface
{
private const EXTENSION_DEFAULT = 'jpg';
private const INSERT_MAX_ATTEMPTS = 15;
- Exclude checks
Function doFormatImage
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
private function doFormatImage(int $imageId, string $formatName): int
{
// find source image
/** @var ResultSet $resultSet */
$resultSet = $this->imageTable->select([
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addImageFromFile
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function addImageFromFile(string $file, string $dirName, array $options = []): int
{
$imageInfo = getimagesize($file);
$width = (int) $imageInfo[0];
Method addImageFromImagick
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function addImageFromImagick(Imagick $imagick, string $dirName, array $options = []): int
{
$width = $imagick->getImageWidth();
$height = $imagick->getImageHeight();
Method changeImageName
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function changeImageName(int $imageId, array $options = []): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
throw new Storage\Exception("Image `$imageId` not found");
Method setImageCrop
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function setImageCrop(int $imageId, ?array $crop): void
{
if (! $imageId) {
throw new Storage\Exception("Invalid image id provided `$imageId`");
}
Method getImageResolution
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getImageResolution(int $imageId): ?array
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
Method getFormatedImageRows
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getFormatedImageRows(array $imagesId, string $formatName): array
{
$destImageRows = [];
if (count($imagesId)) {
$select = $this->imageTable->getSql()->select()
Function getFormatedImageRows
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
private function getFormatedImageRows(array $imagesId, string $formatName): array
{
$destImageRows = [];
if (count($imagesId)) {
$select = $this->imageTable->getSql()->select()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generateLockWrite
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function generateLockWrite(string $dirName, array $options, int $width, int $height, Closure $callback): int
{
$insertAttemptException = null;
$imageId = 0;
$attemptIndex = 0;
Function setImageCrop
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function setImageCrop(int $imageId, ?array $crop): void
{
if (! $imageId) {
throw new Storage\Exception("Invalid image id provided `$imageId`");
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method flush
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function flush(array $options): StorageInterface
{
$defaults = [
'format' => null,
'image' => null,
Method flop
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function flop(int $imageId): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
Method buildImageResult
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function buildImageResult($imageRow): Storage\Image
{
$dir = $this->getDir($imageRow['dir']);
if (! $dir) {
throw new Storage\Exception("Dir '{$imageRow['dir']}' not defined");
Method normalize
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function normalize(int $imageId): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
Function addImageFromFile
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function addImageFromFile(string $file, string $dirName, array $options = []): int
{
$imageInfo = getimagesize($file);
$width = (int) $imageInfo[0];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function changeImageName
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function changeImageName(int $imageId, array $options = []): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
throw new Storage\Exception("Image `$imageId` not found");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function addImageFromImagick
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function addImageFromImagick(Imagick $imagick, string $dirName, array $options = []): int
{
$width = $imagick->getImageWidth();
$height = $imagick->getImageHeight();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generateLockWrite
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function generateLockWrite(string $dirName, array $options, int $width, int $height, Closure $callback): int
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
array $options,
TableGateway $imageTable,
TableGateway $formatedImageTable,
TableGateway $dirTable,
Processor\ProcessorPluginManager $processors
Function getImageResolution
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getImageResolution(int $imageId): ?array
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildImageResult
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function buildImageResult($imageRow): Storage\Image
{
$dir = $this->getDir($imageRow['dir']);
if (! $dir) {
throw new Storage\Exception("Dir '{$imageRow['dir']}' not defined");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method setImageCrop() has an NPath complexity of 960. The configured NPath complexity threshold is 200. Open
public function setImageCrop(int $imageId, ?array $crop): void
{
if (! $imageId) {
throw new Storage\Exception("Invalid image id provided `$imageId`");
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method doFormatImage() has an NPath complexity of 3564. The configured NPath complexity threshold is 200. Open
private function doFormatImage(int $imageId, string $formatName): int
{
// find source image
/** @var ResultSet $resultSet */
$resultSet = $this->imageTable->select([
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The class Storage has 1394 lines of code. Current threshold is 1000. Avoid really long classes. Open
class Storage implements StorageInterface
{
private const EXTENSION_DEFAULT = 'jpg';
private const INSERT_MAX_ATTEMPTS = 15;
- Exclude checks
The method doFormatImage() has 147 lines of code. Current threshold is set to 100. Avoid really long methods. Open
private function doFormatImage(int $imageId, string $formatName): int
{
// find source image
/** @var ResultSet $resultSet */
$resultSet = $this->imageTable->select([
- Exclude checks
The method changeImageName() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function changeImageName(int $imageId, array $options = []): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
throw new Storage\Exception("Image `$imageId` not found");
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method doFormatImage() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10. Open
private function doFormatImage(int $imageId, string $formatName): int
{
// find source image
/** @var ResultSet $resultSet */
$resultSet = $this->imageTable->select([
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getImageResolution() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function getImageResolution(int $imageId): ?array
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method setImageCrop() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function setImageCrop(int $imageId, ?array $crop): void
{
if (! $imageId) {
throw new Storage\Exception("Invalid image id provided `$imageId`");
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Storage has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13. Open
class Storage implements StorageInterface
{
private const EXTENSION_DEFAULT = 'jpg';
private const INSERT_MAX_ATTEMPTS = 15;
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Remove error control operator '@' on line 1115. Open
public function extractEXIF(int $imageId): ?array
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
The method incDirCounter uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->dirTable->insert([
'dir' => $dirName,
'count' => 1,
]);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Laminas\Uri\UriFactory' in method 'buildImageResult'. Open
$uri = UriFactory::factory($url);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function flop(int $imageId): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 223.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function normalize(int $imageId): void
{
$imageRow = $this->getImageRow($imageId);
if (! $imageRow) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 223.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $insertAttemptException. Keep variable name length under 20. Open
$insertAttemptException = null;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $formatedImageTableName. Keep variable name length under 20. Open
private string $formatedImageTableName = 'formated_image';
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $insertAttemptException. Keep variable name length under 20. Open
$insertAttemptException = null;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid variables with short names like $y. Configured minimum length is 3. Open
$y = $info['resolution']['y'];
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = (int) $this->imageTable->getLastInsertValue();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $to. Configured minimum length is 3. Open
$to = (int) pow(10, $attempt) - 1;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = $this->generateLockWrite(
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $x. Configured minimum length is 3. Open
$x = $info['resolution']['x'];
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $s3. Configured minimum length is 3. Open
$s3 = $this->getS3Client();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $s3. Configured minimum length is 3. Open
private S3Client $s3;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $e. Configured minimum length is 3. Open
private function isDuplicateKeyException(Exception $e): bool
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $pi. Configured minimum length is 3. Open
$pi = pathinfo($newPath);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = $this->generateLockWrite(
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}