autowp/zf-components

The class ConfigProvider has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Open

class ConfigProvider
{
    public function __invoke(): array
    {
        return [

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid too many return statements within this method.

Open

            return sprintf(
                $this->view->translatePlural('%1$s minutes ago', null, $minutes),
                $minutes
            );

Avoid too many return statements within this method.

Open

            return $this->view->translate('an hour ago');

Avoid too many return statements within this method.

Open

            return $this->view->translate('in few seconds');

Avoid too many return statements within this method.

Open

        return $this->view->humanDate($time);

The method __invoke has a boolean flag argument $escape, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function __invoke($attribs = [], $content = '', $escape = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

            return $this->view->translate('few seconds ago');

Avoid too many return statements within this method.

Open

            return $this->view->translate('a minute ago');

Avoid too many return statements within this method.

Open

            return $this->view->translate('now');

Avoid too many return statements within this method.

Open

            return sprintf(
                $this->view->translatePlural('%1$s hours ago', null, $hours),
                $hours
            );

Avoid using static access to class '\Laminas\Json\Json' in method 'loadManifest'.

Open

        $content = Json::decode($json, Json::TYPE_ARRAY);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Transliterator' in method 'filter'.

Open

        $tr = Transliterator::create('Any-Latin;Latin-ASCII;');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getRevUrl uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            return $prefix . $file;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method __invoke() has an NPath complexity of 236196. The configured NPath complexity threshold is 200.

Open

    public function __invoke($time)
    {
        if (! $time instanceof DateTime) {
            $dateTime = new DateTime();
            $dateTime->setTimestamp($time);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method __invoke() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.

Open

    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface
    {
        $config     = $container->has('config') ? $container->get('config') : [];
        $mailConfig = $config['mail'] ?? [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method __invoke() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10.

Open

    public function __invoke($time)
    {
        if (! $time instanceof DateTime) {
            $dateTime = new DateTime();
            $dateTime->setTimestamp($time);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Expected 1 newline at end of file; 0 found

Open

];

• Exclude checks
  • Disable engine
  • Disable check

syntax error, unexpected 'array' (T_ARRAY), expecting function (T_FUNCTION) or const (T_CONST)

Open

    private array $manifests = [];

• Exclude checks
  • Disable engine
  • Disable check

Parameter $requestedName is never used

Open

    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TableManager

• Exclude checks
  • Disable engine
  • Disable check

Parameter $options is never used

Open

    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): Helper

• Exclude checks
  • Disable engine
  • Disable check