autowp/zf-components

View on GitHub
src/Mail/Transport/TransportServiceFactory.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method __invoke has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface
    {
        $config     = $container->has('config') ? $container->get('config') : [];
        $mailConfig = $config['mail'] ?? [];

Severity: Minor
Found in src/Mail/Transport/TransportServiceFactory.php - About 1 hr to fix

    Function __invoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface
        {
            $config     = $container->has('config') ? $container->get('config') : [];
            $mailConfig = $config['mail'] ?? [];
    
    
    Severity: Minor
    Found in src/Mail/Transport/TransportServiceFactory.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __invoke() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface
        {
            $config     = $container->has('config') ? $container->get('config') : [];
            $mailConfig = $config['mail'] ?? [];
    
    

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Parameter $options is never used
    Open

        public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface

    Parameter $requestedName is never used
    Open

        public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null): TransportInterface

    Unused definition of variable $transport
    Open

            $transport = null;

    Returning type \Laminas\Mail\transport\file|\Laminas\Mail\transport\inmemory|\Laminas\Mail\transport\sendmail|\Laminas\Mail\transport\smtp but __invoke() is declared to return \Laminas\Mail\Transport\TransportInterface
    Open

            return $transport;

    There are no issues that match your filters.

    Category
    Status