Sign upLogin

avadordi/mass-spectrometry

View on GitHub
Star

Showing 29 of 29 total issues

Function _createWidget has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _createWidget: function( options, element ) {
        element = $( element || this.defaultElement || this )[ 0 ];
        this.element = $( element );
        this.uuid = widget_uuid++;
        this.eventNamespace = "." + this.widgetName + this.uuid;
Severity: Minor
Found in app/assets/javascripts/jquery.ui.widget.js - About 1 hr to fix

    Function _classes has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _classes: function( options ) {
        var full = [],
            that = this;

        options = $.extend( {
    Severity: Minor
    Found in app/assets/javascripts/jquery.ui.widget.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if (!paramNameSlice.length) {
                            paramNameSlice = paramName;
                        }
      Severity: Major
      Found in app/assets/javascripts/z.jquery.fileupload.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (that._trigger(
                        'change',
                        $.Event('change', {delegatedEvent: e}),
                        data
                    ) !== false) {
        Severity: Minor
        Found in app/assets/javascripts/z.jquery.fileupload.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/z.jquery.fileupload.js on lines 1260..1266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (that._trigger(
                            'drop',
                            $.Event('drop', {delegatedEvent: e}),
                            data
                        ) !== false) {
        Severity: Minor
        Found in app/assets/javascripts/z.jquery.fileupload.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/z.jquery.fileupload.js on lines 1220..1226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method start_ssh has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def start_ssh

    rand_dir = SecureRandom.uuid
    mass_datum = MassDatum.find(self.mass_data_id)
    mass_param = MassParam.find(self.mass_params_id)
        Severity: Minor
        Found in app/models/result.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method assign_model_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def assign_model_id(id, model_id)
    current_result = current_user.current_result
    if current_result
      if model_id == :mass_data_id then current_result.mass_data_id = id else current_result.mass_params_id = id end
      current_result.save
        Severity: Minor
        Found in app/controllers/application_controller.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method finish has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def finish
    # final results
    if !current_user.current_result
      #error
      flash[:warning] = "Please upload files to run."
        Severity: Minor
        Found in app/controllers/results_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function s3_upload_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        var s3_upload_file = function(url, formData) {
  $('.directUpload').find("input:file").each(function(i, elem) {

    var fileInput    = $(elem);
    var form         = $('.directUpload').find('form:first');
        Severity: Minor
        Found in app/assets/javascripts/s3.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language