Sign upLogin

avaframe/AvaFrame

View on GitHub
Star
avaframe/com1DFAOrig/com1DFAOrig.py

Summary

Maintainability
D
3 days
Test Coverage
F
0%

Function com1DFAOrigMain has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

def com1DFAOrigMain(cfg, avaDir):
    """ Run main model

    This will compute a dense flow avalanche
Severity: Minor
Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File com1DFAOrig.py has 372 lines of code (exceeds 300 allowed). Consider refactoring.
Open

"""
    Python wrapper to execute the compiled com1Exe file and set desired simulation options
"""

# Load modules
Severity: Minor
Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 3 hrs to fix

    Function getSimulation has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    def getSimulation(cfg, rel, entResInfo):
    """ Get a list of all simulations that shall be performed according to simTypeList in configuration file;
        and a dictionary with information on release area
    Severity: Minor
    Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execCom1Exe has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def execCom1Exe(com1Exe, cintFile, avaDir, fullOut=False, simName=''):
    """ Execute compiled com1Exe file using cintFile to set configuration
        and run options

        Parameters
    Severity: Minor
    Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if resInfo == 'Yes':
                        reportVar['Resistance area'] = {'type': 'columns', 'Resistance area scenario': resistanceArea}
    Severity: Major
    Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if cfgPar['varPar'] == 'RelTh':
                        reportVar['Simulation Parameters'].update({'Mu': defValues['Mu']})
                        reportVar['Simulation Parameters'].update({'Release thickness [m]': item})
                        reportVar['Simulation Parameters'].update({'Entrainment thickness [m]': float(entrainmentTH)})
                        reportVar['Release area'].update({'Release thickness [m]': item})
      Severity: Major
      Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if entInfo == 'Yes':
                        reportVar['Entrainment area'] = {'type': 'columns', 'Entrainment area scenario': entrainmentArea, 'Entrainment thickness [m]': float(entrainmentTH)}
                    if resInfo == 'Yes':
        Severity: Major
        Found in avaframe/com1DFAOrig/com1DFAOrig.py - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if 'res' in simTypeList or 'entres' in simTypeList:
        if entResInfo['flagRes'] == 'No':
            log.error('No resistance file found')
            raise FileNotFoundError
          Severity: Major
          Found in avaframe/com1DFAOrig/com1DFAOrig.py and 1 other location - About 1 hr to fix
          avaframe/com1DFAOrig/com1DFAOrig.py on lines 150..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if 'ent' in simTypeList or 'entres' in simTypeList:
        if entResInfo['flagEnt'] == 'No':
            log.error('No entrainment file found')
            raise FileNotFoundError
          Severity: Major
          Found in avaframe/com1DFAOrig/com1DFAOrig.py and 1 other location - About 1 hr to fix
          avaframe/com1DFAOrig/com1DFAOrig.py on lines 154..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for dict in dictList:
            pickle.dump(dict, open(os.path.join(outDir, "particles%09.4f.p" % (dict['t'])), "wb"))
          Severity: Minor
          Found in avaframe/com1DFAOrig/com1DFAOrig.py and 1 other location - About 50 mins to fix
          avaframe/com1DFAOrig/com1DFAOrig.py on lines 513..517

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if isinstance(dictList, list):
        for dict in dictList:
            pickle.dump(dict, open(os.path.join(outDir, "particles%09.4f.p" % (dict['t'])), "wb"))
    else:
        pickle.dump(dictList, open(os.path.join(outDir, "particles%09.4f.p" % (dictList['t'])), "wb"))
          Severity: Minor
          Found in avaframe/com1DFAOrig/com1DFAOrig.py and 1 other location - About 50 mins to fix
          avaframe/com1DFAOrig/com1DFAOrig.py on lines 514..515

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status