avalanche-development/swagger-validation-middleware

View on GitHub
src/Parameter/ParameterCheck.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method checkParamValue has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function checkParamValue(array $param)
    {
        if ($param['type'] === 'array') {
            $this->checkItems($param);

Severity: Minor
Found in src/Parameter/ParameterCheck.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return;
    Severity: Major
    Found in src/Parameter/ParameterCheck.php - About 30 mins to fix

      Function checkItems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function checkItems(array $param)
          {
              if (isset($param['maxItems']) && $param['maxItems'] < count($param['value'])) {
                  throw new ValidationException('Size of array exceeds maxItems');
              }
      Severity: Minor
      Found in src/Parameter/ParameterCheck.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Expected 1 space after FOREACH keyword; 0 found
      Open

              foreach($requiredProperties as $requiredProperty) {

      There are no issues that match your filters.

      Category
      Status