Sign upLogin

aviator/aviator

View on GitHub
Star
lib/aviator/core/cli/describer.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method describe_request has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def self.describe_request(provider_name, service_name, api_version, endpoint_type, request_name)
      service = Aviator::Service.new :provider => provider_name, :service => service_name
      request_class = "Aviator::#{ StrUtil.camelize(provider_name) }::#{ StrUtil.camelize(service_name) }::Requests::"\
                      "#{ StrUtil.camelize(api_version) }::#{ StrUtil.camelize(endpoint_type) }::#{ StrUtil.camelize(request_name) }"
      request_class = StrUtil.constantize(request_class)
Severity: Minor
Found in lib/aviator/core/cli/describer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method describe_request has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.describe_request(provider_name, service_name, api_version, endpoint_type, request_name)
      service = Aviator::Service.new :provider => provider_name, :service => service_name
      request_class = "Aviator::#{ StrUtil.camelize(provider_name) }::#{ StrUtil.camelize(service_name) }::Requests::"\
                      "#{ StrUtil.camelize(api_version) }::#{ StrUtil.camelize(endpoint_type) }::#{ StrUtil.camelize(request_name) }"
      request_class = StrUtil.constantize(request_class)
Severity: Minor
Found in lib/aviator/core/cli/describer.rb - About 1 hr to fix

    Method describe_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.describe_request(provider_name, service_name, api_version, endpoint_type, request_name)
    Severity: Minor
    Found in lib/aviator/core/cli/describer.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status