avocado-framework/avocado

View on GitHub

Showing 761 of 779 total issues

File process.py has 976 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
Severity: Major
Found in avocado/utils/process.py - About 2 days to fix

    File test_basic.py has 886 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import glob
    import json
    import os
    import re
    import tempfile
    Severity: Major
    Found in selftests/functional/test_basic.py - About 2 days to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_filter_fast_net_include_empty(self):
              filtered = tags.filter_test_tags(self.test_suite, ['fast,net'], True, False)
              self.assertEqual(len(filtered), 3)
              self.assertEqual(filtered[0][0], 'FastTest')
              self.assertEqual(filtered[0][1]['methodName'], 'test_fast')
      Severity: Major
      Found in selftests/unit/test_tags.py and 1 other location - About 1 day to fix
      selftests/unit/test_tags.py on lines 157..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_filter_arch_include_empty(self):
              filtered = tags.filter_test_tags(self.test_suite, ['arch'], True, False)
              self.assertEqual(len(filtered), 3)
              self.assertEqual(filtered[0][0], 'SafeX86Test')
              self.assertEqual(filtered[0][1]['methodName'], 'test_safe_x86')
      Severity: Major
      Found in selftests/unit/test_tags.py and 1 other location - About 1 day to fix
      selftests/unit/test_tags.py on lines 139..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_too_many(self):
              events = self.parse_tap('ok 1\nnot ok 2\n1..1')
              self.assert_test(events, number=1, name='', result=TestResult.PASS)
              self.assert_test(events, number=2, name='', result=TestResult.FAIL)
              self.assert_plan(events, count=1, late=True)
      Severity: Major
      Found in selftests/unit/test_tap.py and 1 other location - About 1 day to fix
      selftests/unit/test_tap.py on lines 214..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 180.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def test_too_few(self):
              events = self.parse_tap('ok 1\nnot ok 2\n1..3')
              self.assert_test(events, number=1, name='', result=TestResult.PASS)
              self.assert_test(events, number=2, name='', result=TestResult.FAIL)
              self.assert_plan(events, count=3, late=True)
      Severity: Major
      Found in selftests/unit/test_tap.py and 1 other location - About 1 day to fix
      selftests/unit/test_tap.py on lines 199..212

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 180.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File test.py has 674 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # This program is free software; you can redistribute it and/or modify
      # it under the terms of the GNU General Public License as published by
      # the Free Software Foundation; specifically version 2 of the License.
      #
      # This program is distributed in the hope that it will be useful,
      Severity: Major
      Found in avocado/core/test.py - About 1 day to fix

        Function parse has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
        Open

            def parse(self):
                found_late_test = False
                bailed_out = False
                plan = None
                lineno = 0
        Severity: Minor
        Found in avocado/core/tapparser.py - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def test_success_install(self):
        
                self.mock_sm.return_value.check_installed = lambda check_installed: False
                self.mock_sm.return_value.install = lambda install: True
                runnable = Runnable(kind='package', uri=None,
        Severity: Major
        Found in selftests/unit/test_runner_package.py and 3 other locations - About 1 day to fix
        selftests/unit/test_runner_package.py on lines 90..106
        selftests/unit/test_runner_package.py on lines 108..124
        selftests/unit/test_runner_package.py on lines 143..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 159.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def test_fail_install(self):
        
                self.mock_sm.return_value.check_installed = lambda check_installed: False
                self.mock_sm.return_value.install = lambda install: False
                runnable = Runnable(kind='package', uri=None,
        Severity: Major
        Found in selftests/unit/test_runner_package.py and 3 other locations - About 1 day to fix
        selftests/unit/test_runner_package.py on lines 55..71
        selftests/unit/test_runner_package.py on lines 108..124
        selftests/unit/test_runner_package.py on lines 143..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 159.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def test_success_remove(self):
        
                self.mock_sm.return_value.check_installed = lambda check_installed: True
                self.mock_sm.return_value.remove = lambda remove: True
                runnable = Runnable(kind='package', uri=None,
        Severity: Major
        Found in selftests/unit/test_runner_package.py and 3 other locations - About 1 day to fix
        selftests/unit/test_runner_package.py on lines 55..71
        selftests/unit/test_runner_package.py on lines 90..106
        selftests/unit/test_runner_package.py on lines 143..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 159.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            def test_fail_remove(self):
        
                self.mock_sm.return_value.check_installed = lambda check_installed: True
                self.mock_sm.return_value.remove = lambda remove: False
                runnable = Runnable(kind='package', uri=None,
        Severity: Major
        Found in selftests/unit/test_runner_package.py and 3 other locations - About 1 day to fix
        selftests/unit/test_runner_package.py on lines 55..71
        selftests/unit/test_runner_package.py on lines 90..106
        selftests/unit/test_runner_package.py on lines 108..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 159.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @skipUnlessPathExists('/bin/sh')
            def test_runner_tap_fail(self):
                tap_script = """#!/bin/sh
        echo '1..2'
        echo '# Defining an basic test'
        Severity: Major
        Found in selftests/unit/test_nrunner.py and 4 other locations - About 1 day to fix
        selftests/unit/test_nrunner.py on lines 310..328
        selftests/unit/test_nrunner.py on lines 330..348
        selftests/unit/test_nrunner.py on lines 350..368
        selftests/unit/test_nrunner.py on lines 370..388

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @skipUnlessPathExists('/bin/sh')
            def test_runner_tap_skip(self):
                tap_script = """#!/bin/sh
        echo '1..2'
        echo '# Defining an basic test'
        Severity: Major
        Found in selftests/unit/test_nrunner.py and 4 other locations - About 1 day to fix
        selftests/unit/test_nrunner.py on lines 290..308
        selftests/unit/test_nrunner.py on lines 310..328
        selftests/unit/test_nrunner.py on lines 350..368
        selftests/unit/test_nrunner.py on lines 370..388

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @skipUnlessPathExists('/bin/sh')
            def test_runner_tap_ok(self):
                tap_script = """#!/bin/sh
        echo '1..2'
        echo '# Defining an basic test'
        Severity: Major
        Found in selftests/unit/test_nrunner.py and 4 other locations - About 1 day to fix
        selftests/unit/test_nrunner.py on lines 290..308
        selftests/unit/test_nrunner.py on lines 330..348
        selftests/unit/test_nrunner.py on lines 350..368
        selftests/unit/test_nrunner.py on lines 370..388

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @skipUnlessPathExists('/bin/sh')
            def test_runner_tap_error(self):
                tap_script = """#!/bin/sh
        echo '1..2'
        echo '# Defining an basic test'
        Severity: Major
        Found in selftests/unit/test_nrunner.py and 4 other locations - About 1 day to fix
        selftests/unit/test_nrunner.py on lines 290..308
        selftests/unit/test_nrunner.py on lines 310..328
        selftests/unit/test_nrunner.py on lines 330..348
        selftests/unit/test_nrunner.py on lines 350..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @skipUnlessPathExists('/bin/sh')
            def test_runner_tap_bailout(self):
                tap_script = """#!/bin/sh
        echo '1..2'
        echo '# Defining an basic test'
        Severity: Major
        Found in selftests/unit/test_nrunner.py and 4 other locations - About 1 day to fix
        selftests/unit/test_nrunner.py on lines 290..308
        selftests/unit/test_nrunner.py on lines 310..328
        selftests/unit/test_nrunner.py on lines 330..348
        selftests/unit/test_nrunner.py on lines 370..388

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File gdb.py has 618 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # This program is free software; you can redistribute it and/or modify
        # it under the terms of the GNU General Public License as published by
        # the Free Software Foundation; either version 2 of the License, or
        # (at your option) any later version.
        #
        Severity: Major
        Found in avocado/utils/gdb.py - About 1 day to fix

          File output.py has 598 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # This program is free software; you can redistribute it and/or modify
          # it under the terms of the GNU General Public License as published by
          # the Free Software Foundation; either version 2 of the License, or
          # (at your option) any later version.
          #
          Severity: Major
          Found in avocado/core/output.py - About 1 day to fix

            File service.py has 597 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            #  Copyright(c) 2013 Intel Corporation.
            #
            #  This program is free software; you can redistribute it and/or modify it
            #  under the terms and conditions of the GNU General Public License,
            #  version 2, as published by the Free Software Foundation.
            Severity: Major
            Found in avocado/utils/service.py - About 1 day to fix
              Severity
              Category
              Status
              Source
              Language