avocado-framework/avocado

View on GitHub

Showing 1,262 of 1,291 total issues

File process.py has 1182 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
Severity: Major
Found in avocado/utils/process.py - About 3 days to fix

    File test.py has 1090 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # This program is free software; you can redistribute it and/or modify
    # it under the terms of the GNU General Public License as published by
    # the Free Software Foundation; specifically version 2 of the License.
    #
    # This program is distributed in the hope that it will be useful,
    Severity: Major
    Found in avocado/core/test.py - About 2 days to fix

      File test_basic.py has 1071 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import glob
      import json
      import os
      import re
      import tempfile
      Severity: Major
      Found in selftests/functional/test_basic.py - About 2 days to fix

        File nrunner.py has 1006 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        #!/usr/bin/env python3
        
        import abc
        import argparse
        import base64
        Severity: Major
        Found in avocado/core/nrunner.py - About 2 days to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class BasicTests(unittest.TestCase):
              """Basic unit tests for the RequirementAssetRunner class"""
          
              def test_no_kwargs(self):
                  runnable = Runnable(kind='requirement-asset', uri=None)
          Severity: Major
          Found in selftests/unit/test_runner_requirement_asset.py and 1 other location - About 2 days to fix
          selftests/unit/test_runner_requirement_package.py on lines 8..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 259.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class BasicTests(unittest.TestCase):
              """Basic unit tests for the RequirementPackageRunner class"""
          
              def test_no_kwargs(self):
                  runnable = Runnable(kind='requirement-package', uri=None)
          Severity: Major
          Found in selftests/unit/test_runner_requirement_package.py and 1 other location - About 2 days to fix
          selftests/unit/test_runner_requirement_asset.py on lines 8..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 259.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def test_asset_fetch_find_fail_cancel(self):
                  """
                  Test cancels
                  Asset is not found in the cache
                  """
          Severity: Major
          Found in selftests/functional/test_fetch_asset.py and 2 other locations - About 1 day to fix
          selftests/functional/test_fetch_asset.py on lines 73..105
          selftests/functional/test_fetch_asset.py on lines 140..170

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 183.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def test_asset_fetch_cancel(self):
                  """
                  Test cancels
                  Failed to fetch asset
                  """
          Severity: Major
          Found in selftests/functional/test_fetch_asset.py and 2 other locations - About 1 day to fix
          selftests/functional/test_fetch_asset.py on lines 73..105
          selftests/functional/test_fetch_asset.py on lines 107..138

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 183.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def test_asset_fetch_find_fail(self):
                  """
                  Test fails
                  Asset is not found in the cache
                  """
          Severity: Major
          Found in selftests/functional/test_fetch_asset.py and 2 other locations - About 1 day to fix
          selftests/functional/test_fetch_asset.py on lines 107..138
          selftests/functional/test_fetch_asset.py on lines 140..170

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 183.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_too_many(self):
                  events = self.parse_tap('ok 1\nnot ok 2\n1..1')
                  self.assert_test(events, number=1, name='', result=TestResult.PASS)
                  self.assert_test(events, number=2, name='', result=TestResult.FAIL)
                  self.assert_plan(events, count=1, late=True)
          Severity: Major
          Found in selftests/unit/test_tap.py and 1 other location - About 1 day to fix
          selftests/unit/test_tap.py on lines 214..227

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 180.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_too_few(self):
                  events = self.parse_tap('ok 1\nnot ok 2\n1..3')
                  self.assert_test(events, number=1, name='', result=TestResult.PASS)
                  self.assert_test(events, number=2, name='', result=TestResult.FAIL)
                  self.assert_plan(events, count=3, late=True)
          Severity: Major
          Found in selftests/unit/test_tap.py and 1 other location - About 1 day to fix
          selftests/unit/test_tap.py on lines 199..212

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 180.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_change_unexpected_remove(self):
                  files = self.files
                  with open(files[0], "w") as f:
                      f.write("this line is removed\n")
          
          
          Severity: Major
          Found in selftests/unit/utils/test_diff_validator.py and 1 other location - About 1 day to fix
          selftests/unit/utils/test_diff_validator.py on lines 106..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 175.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_change_unexpected_add(self):
                  files = self.files
                  with open(files[0], "w") as f:
                      f.write("this line is removed\n")
          
          
          Severity: Major
          Found in selftests/unit/utils/test_diff_validator.py and 1 other location - About 1 day to fix
          selftests/unit/utils/test_diff_validator.py on lines 88..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 175.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function parse has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse(self):
                  found_late_test = False
                  bailed_out = False
                  plan = None
                  lineno = 0
          Severity: Minor
          Found in avocado/core/tapparser.py - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def test_success_remove(self):
          
                  self.mock_sm.return_value.check_installed = lambda check_installed: True
                  self.mock_sm.return_value.remove = lambda remove: True
                  runnable = Runnable(kind='requirement-package', uri=None,
          Severity: Major
          Found in selftests/unit/test_runner_requirement_package.py and 3 other locations - About 1 day to fix
          selftests/unit/test_runner_requirement_package.py on lines 55..72
          selftests/unit/test_runner_requirement_package.py on lines 92..109
          selftests/unit/test_runner_requirement_package.py on lines 148..165

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def test_success_install(self):
          
                  self.mock_sm.return_value.check_installed = lambda check_installed: False
                  self.mock_sm.return_value.install = lambda install: True
                  runnable = Runnable(kind='requirement-package', uri=None,
          Severity: Major
          Found in selftests/unit/test_runner_requirement_package.py and 3 other locations - About 1 day to fix
          selftests/unit/test_runner_requirement_package.py on lines 92..109
          selftests/unit/test_runner_requirement_package.py on lines 111..128
          selftests/unit/test_runner_requirement_package.py on lines 148..165

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def test_fail_install(self):
          
                  self.mock_sm.return_value.check_installed = lambda check_installed: False
                  self.mock_sm.return_value.install = lambda install: False
                  runnable = Runnable(kind='requirement-package', uri=None,
          Severity: Major
          Found in selftests/unit/test_runner_requirement_package.py and 3 other locations - About 1 day to fix
          selftests/unit/test_runner_requirement_package.py on lines 55..72
          selftests/unit/test_runner_requirement_package.py on lines 111..128
          selftests/unit/test_runner_requirement_package.py on lines 148..165

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              def test_fail_remove(self):
          
                  self.mock_sm.return_value.check_installed = lambda check_installed: True
                  self.mock_sm.return_value.remove = lambda remove: False
                  runnable = Runnable(kind='requirement-package', uri=None,
          Severity: Major
          Found in selftests/unit/test_runner_requirement_package.py and 3 other locations - About 1 day to fix
          selftests/unit/test_runner_requirement_package.py on lines 55..72
          selftests/unit/test_runner_requirement_package.py on lines 92..109
          selftests/unit/test_runner_requirement_package.py on lines 111..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_unsupported_status(self):
                  with script.TemporaryScript("fake_status.py",
                                              UNSUPPORTED_STATUS_TEST_CONTENTS,
                                              "avocado_unsupported_status") as tst:
                      res = process.run("%s run --disable-sysinfo --job-results-dir %s %s"
          Severity: Major
          Found in selftests/functional/test_basic.py and 1 other location - About 1 day to fix
          selftests/functional/test_basic.py on lines 285..299

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 161.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_no_status_reported(self):
                  with script.TemporaryScript("die_without_reporting_status.py",
                                              DIE_WITHOUT_REPORTING_STATUS,
                                              "no_status_reported") as tst:
                      res = process.run("%s run --disable-sysinfo --job-results-dir %s %s "
          Severity: Major
          Found in selftests/functional/test_basic.py and 1 other location - About 1 day to fix
          selftests/functional/test_basic.py on lines 241..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 161.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language