awarebayes/RecNN

View on GitHub

Showing 19 of 19 total issues

File env.py has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from . import utils, dataset_functions as dset_F
from .pandas_backend import pd
import pickle
from torch.utils.data import Dataset, DataLoader
from sklearn.model_selection import train_test_split
Severity: Minor
Found in recnn/data/env.py - About 3 hrs to fix

    Function bcq_update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def bcq_update(
        batch,
        params,
        nets,
        optimizer,
    Severity: Minor
    Found in recnn/nn/update/bcq.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reinforce_update has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def reinforce_update(
    Severity: Major
    Found in recnn/nn/update/reinforce.py - About 1 hr to fix

      Function td3_update has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def td3_update(
      Severity: Major
      Found in recnn/nn/update/td3.py - About 1 hr to fix

        Function ddpg_update has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def ddpg_update(
        Severity: Major
        Found in recnn/nn/update/ddpg.py - About 1 hr to fix

          Function bcq_update has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def bcq_update(
          Severity: Major
          Found in recnn/nn/update/bcq.py - About 1 hr to fix

            Function value_update has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def value_update(
            Severity: Major
            Found in recnn/nn/update/misc.py - About 1 hr to fix

              Function _select_action_with_TopK_correction has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _select_action_with_TopK_correction(
              Severity: Major
              Found in recnn/nn/models.py - About 50 mins to fix

                Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(
                Severity: Minor
                Found in recnn/data/env.py - About 45 mins to fix

                  Function batch_contstate_discaction has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def batch_contstate_discaction(
                  Severity: Minor
                  Found in recnn/data/utils.py - About 45 mins to fix

                    Function _select_action_with_correction has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def _select_action_with_correction(
                    Severity: Minor
                    Found in recnn/nn/models.py - About 45 mins to fix

                      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def __init__(
                      Severity: Minor
                      Found in recnn/data/env.py - About 35 mins to fix

                        Function batch_tensor_embeddings has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def batch_tensor_embeddings(batch, item_embeddings_tensor, frame_size, *args, **kwargs):
                        Severity: Minor
                        Found in recnn/data/utils.py - About 35 mins to fix

                          Identical blocks of code found in 3 locations. Consider refactoring.
                          Open

                              done[torch.cumsum(sizes_t - frame_size, dim=0) - 1] = 1
                          Severity: Minor
                          Found in recnn/data/utils.py and 2 other locations - About 35 mins to fix
                          recnn/data/utils.py on lines 37..37
                          recnn/data/utils.py on lines 107..107

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 33.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function td3_update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def td3_update(
                              batch,
                              params,
                              nets,
                              optimizer,
                          Severity: Minor
                          Found in recnn/nn/update/td3.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 3 locations. Consider refactoring.
                          Open

                              done[torch.cumsum(sizes_t - frame_size, dim=0) - 1] = 1
                          Severity: Minor
                          Found in recnn/data/utils.py and 2 other locations - About 35 mins to fix
                          recnn/data/utils.py on lines 71..71
                          recnn/data/utils.py on lines 107..107

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 33.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 3 locations. Consider refactoring.
                          Open

                              done[torch.cumsum(sizes_t - frame_size, dim=0) - 1] = 1
                          Severity: Minor
                          Found in recnn/data/utils.py and 2 other locations - About 35 mins to fix
                          recnn/data/utils.py on lines 37..37
                          recnn/data/utils.py on lines 71..71

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 33.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  utils.soft_update(
                                      nets["policy_net"], nets["target_policy_net"], soft_tau=params["soft_tau"]
                          Severity: Minor
                          Found in recnn/nn/update/reinforce.py and 1 other location - About 30 mins to fix
                          recnn/nn/update/reinforce.py on lines 114..115

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 32.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  utils.soft_update(
                                      nets["value_net"], nets["target_value_net"], soft_tau=params["soft_tau"]
                          Severity: Minor
                          Found in recnn/nn/update/reinforce.py and 1 other location - About 30 mins to fix
                          recnn/nn/update/reinforce.py on lines 117..118

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 32.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language