Sign upLogin

aws/aws-codedeploy-agent

View on GitHub
Star
lib/instance_agent/plugins/codedeploy/command_executor.rb

Summary

Maintainability
F
3 days
Test Coverage

File command_executor.rb has 504 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'openssl'
require 'fileutils'
require 'aws-sdk-core'
require 'aws-sdk-s3'
require 'zlib'
Severity: Major
Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 1 day to fix

    Class CommandExecutor has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class CommandExecutor
        class << self
          attr_reader :command_methods
        end
    Severity: Minor
    Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 4 hrs to fix

      Method download_from_s3 has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

              def download_from_s3(deployment_spec, bucket, key, version, etag)
          log(:info, "Downloading artifact bundle from bucket '#{bucket}' and key '#{key}', version '#{version}', etag '#{etag}'")
          options = s3_options()
          s3 = Aws::S3::Client.new(options)
      Severity: Minor
      Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method download_from_github has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

              def download_from_github(deployment_spec, account, repo, commit, anonymous, token)

          retries = 0
          errors = []
      Severity: Minor
      Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method download_from_github has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def download_from_github(deployment_spec, account, repo, commit, anonymous, token)

          retries = 0
          errors = []
      Severity: Minor
      Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 1 hr to fix

        Method unpack_bundle has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def unpack_bundle(cmd, bundle_file, deployment_spec)
          dst = File.join(deployment_root_dir(deployment_spec), 'deployment-archive')

          if "tar".eql? deployment_spec.bundle_type
            InstanceAgent::Platform.util.extract_tar(bundle_file, dst)
        Severity: Minor
        Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 1 hr to fix

          Method unpack_bundle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

                  def unpack_bundle(cmd, bundle_file, deployment_spec)
          dst = File.join(deployment_root_dir(deployment_spec), 'deployment-archive')

          if "tar".eql? deployment_spec.bundle_type
            InstanceAgent::Platform.util.extract_tar(bundle_file, dst)
          Severity: Minor
          Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method download_from_s3 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def download_from_s3(deployment_spec, bucket, key, version, etag)
          log(:info, "Downloading artifact bundle from bucket '#{bucket}' and key '#{key}', version '#{version}', etag '#{etag}'")
          options = s3_options()
          s3 = Aws::S3::Client.new(options)
          Severity: Minor
          Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 1 hr to fix

            Method validate_app_spec_hooks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    def validate_app_spec_hooks(app_spec_location, all_possible_lifecycle_events)
          app_spec = ApplicationSpecification::ApplicationSpecification.parse(File.read(app_spec_location))
          app_spec_filename = File.basename(app_spec_location)
          unless all_possible_lifecycle_events.nil?
            app_spec_hooks_plus_hooks_from_mapping = app_spec.hooks.keys.to_set.merge(@hook_mapping.keys).to_a
            Severity: Minor
            Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method download_from_github has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def download_from_github(deployment_spec, account, repo, commit, anonymous, token)
            Severity: Minor
            Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 45 mins to fix

              Method is_command_noop? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def is_command_noop?(command_name, deployment_spec)
          deployment_spec = InstanceAgent::Plugins::CodeDeployPlugin::DeploymentSpecification.parse(deployment_spec)

          # DownloadBundle and Install are never noops.
          return false if command_name == "Install" || command_name == "DownloadBundle"
              Severity: Minor
              Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method download_from_s3 has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def download_from_s3(deployment_spec, bucket, key, version, etag)
              Severity: Minor
              Found in lib/instance_agent/plugins/codedeploy/command_executor.rb - About 35 mins to fix

                Identical blocks of code found in 6 locations. Consider refactoring.
                Open

                        def log(severity, message)
          raise ArgumentError, "Unknown severity #{severity.inspect}" unless InstanceAgent::Log::SEVERITIES.include?(severity.to_s)
          InstanceAgent::Log.send(severity.to_sym, "#{description}: #{message}")
                Severity: Minor
                Found in lib/instance_agent/plugins/codedeploy/command_executor.rb and 5 other locations - About 15 mins to fix
                lib/instance_agent/agent/base.rb on lines 19..21
                lib/instance_agent/plugins/codedeploy/hook_executor.rb on lines 290..292
                lib/instance_agent/plugins/codedeploy/install_instruction.rb on lines 195..197
                lib/instance_agent/plugins/codedeploy/installer.rb on lines 156..158
                lib/winagent.rb on lines 67..69

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status