awsmug/torro-forms-plugin-boilerplate

View on GitHub

Showing 34 of 34 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function( $, scriptData ) {
    'use strict';

    function getDataProperty( propertyPath, data ) {
        var currentProperty;
Severity: Major
Found in assets/src/js/autocomplete-element.js and 1 other location - About 4 days to fix
assets/dist/js/autocomplete-element.js on lines 5..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 801.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function( $, scriptData ) {
    'use strict';

    function getDataProperty( propertyPath, data ) {
        var currentProperty;
Severity: Major
Found in assets/dist/js/autocomplete-element.js and 1 other location - About 4 days to fix
assets/src/js/autocomplete-element.js on lines 1..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 801.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function filter_json has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function filter_json( $data, $element, $submission = null ) {
        $data = parent::filter_json( $data, $element, $submission );

        $settings = $this->get_settings( $element );

Severity: Minor
Found in src/element-types/autocomplete.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter_json has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function filter_json( $data, $element, $submission = null ) {
        $data = parent::filter_json( $data, $element, $submission );

        $settings = $this->get_settings( $element );

Severity: Minor
Found in src/element-types/autocomplete.php - About 1 hr to fix

    Method filter_json has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function filter_json( $data, $element, $submission = null ) {
            global $wp_locale;
    
            $data = parent::filter_json( $data, $element, $submission );
    
    
    Severity: Minor
    Found in src/element-types/date.php - About 1 hr to fix

      Function source has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  source: function( request, response ) {
                      var restUrl = scriptData.restUrl + searchRoute.replace( '%search%', request.term );
      
                      $.ajax( restUrl, {
                          method:   'GET',
      Severity: Minor
      Found in assets/src/js/autocomplete-element.js - About 1 hr to fix

        Function source has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    source: function( request, response ) {
                        var restUrl = scriptData.restUrl + searchRoute.replace( '%search%', request.term );
        
                        $.ajax( restUrl, {
                            method:   'GET',
        Severity: Minor
        Found in assets/dist/js/autocomplete-element.js - About 1 hr to fix

          Function validate_field has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validate_field( $value, $element, $submission ) {
                  $settings = $this->get_settings( $element );
          
                  // Support Y-m-d string passed, just so that submission editing with single field works too.
                  if ( is_string( $value ) && 2 === substr_count( $value, '-' ) ) {
          Severity: Minor
          Found in src/element-types/date.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if ( ! isset( $item->$property ) ) {
                                      $not_found = true;
                                      break;
                                  }
          Severity: Major
          Found in src/element-types/autocomplete.php - About 45 mins to fix

            Method process_response has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected function process_response( $response, $connection, $route_slug, $submission, $form ) {
            Severity: Minor
            Found in src/actions/frontend-posting.php - About 35 mins to fix

              Function validate_field has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function validate_field( $value, $element, $submission ) {
                      $settings = $this->get_settings( $element );
              
                      $value = (int) trim( $value );
              
              
              Severity: Minor
              Found in src/element-types/autocomplete.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      foreach ( $post_types as $post_type ) {
                          $rest_base = ! empty( $post_type->rest_base ) ? $post_type->rest_base : $post_type->name;
              
                          $datasources[ 'post_type_' . $post_type->name ] = array(
                              'label'                         => $post_type->label,
              Severity: Minor
              Found in src/element-types/autocomplete.php and 1 other location - About 30 mins to fix
              src/element-types/autocomplete.php on lines 179..189

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      foreach ( $taxonomies as $taxonomy ) {
                          $rest_base = ! empty( $taxonomy->rest_base ) ? $taxonomy->rest_base : $taxonomy->name;
              
                          $datasources[ 'taxonomy_' . $taxonomy->name ] = array(
                              'label'                         => $taxonomy->label,
              Severity: Minor
              Found in src/element-types/autocomplete.php and 1 other location - About 30 mins to fix
              src/element-types/autocomplete.php on lines 166..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                      return $parsed_value;
              Severity: Major
              Found in src/element-types/date.php - About 30 mins to fix

                Function detect_date_fields_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function detect_date_fields_order() {
                        $date_format = get_option( 'date_format' );
                        $date_format = str_split( $date_format );
                
                        $year_group  = array( 'Y', 'y' );
                Severity: Minor
                Found in src/element-types/date.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid using static access to class '\WP_REST_Request' in method 'filter_json'.
                Open

                            $request  = WP_REST_Request::from_url( $rest_url );
                Severity: Minor
                Found in src/element-types/autocomplete.php by phpmd

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
                {
                    public function bar()
                    {
                        Bar::baz();
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                Avoid unused parameters such as '$submission'.
                Open

                    public function validate_field( $value, $element, $submission ) {
                Severity: Minor
                Found in src/element-types/date.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$route_slug'.
                Open

                    protected function process_response( $response, $connection, $route_slug, $submission, $form ) {
                Severity: Minor
                Found in src/actions/frontend-posting.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$submission'.
                Open

                    protected function process_response( $response, $connection, $route_slug, $submission, $form ) {
                Severity: Minor
                Found in src/actions/frontend-posting.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$submission'.
                Open

                    public function validate_field( $value, $element, $submission ) {
                Severity: Minor
                Found in src/element-types/autocomplete.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Severity
                Category
                Status
                Source
                Language