Sign upLogin

awsmug/torro-forms

View on GitHub
Star
src/components/form-upload-manager.php

Summary

Maintainability
C
1 day
Test Coverage

Method upload_file has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function upload_file( $file_id, $submission, $form, $element_id, $field = '_main', $allowed_mimes = null, $allowed_filesize = null ) {
        if ( ! isset( $_FILES[ $file_id ] ) ) {
            return new WP_Error( 'missing_file', __( 'No file was provided to upload.', 'torro-forms' ) );
        }
Severity: Major
Found in src/components/form-upload-manager.php - About 2 hrs to fix

    Function upload_file has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function upload_file( $file_id, $submission, $form, $element_id, $field = '_main', $allowed_mimes = null, $allowed_filesize = null ) {
        if ( ! isset( $_FILES[ $file_id ] ) ) {
            return new WP_Error( 'missing_file', __( 'No file was provided to upload.', 'torro-forms' ) );
        }
    Severity: Minor
    Found in src/components/form-upload-manager.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete_old_files has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function delete_old_files( $submission, $form, $element_id, $field = '_main', $ignore_id = 0 ) {
        $prefix = $this->get_prefix();

        if ( ! $field ) {
            $field = '_main';
    Severity: Minor
    Found in src/components/form-upload-manager.php - About 1 hr to fix

      Method upload_file has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function upload_file( $file_id, $submission, $form, $element_id, $field = '_main', $allowed_mimes = null, $allowed_filesize = null ) {
      Severity: Major
      Found in src/components/form-upload-manager.php - About 50 mins to fix

        Method delete_old_files has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function delete_old_files( $submission, $form, $element_id, $field = '_main', $ignore_id = 0 ) {
        Severity: Minor
        Found in src/components/form-upload-manager.php - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $attachment_id;
          Severity: Major
          Found in src/components/form-upload-manager.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new WP_Error( 'upload_error', __( 'The file could not be registered with the database.', 'torro-forms' ) );
            Severity: Major
            Found in src/components/form-upload-manager.php - About 30 mins to fix

              Function delete_old_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function delete_old_files( $submission, $form, $element_id, $field = '_main', $ignore_id = 0 ) {
        $prefix = $this->get_prefix();

        if ( ! $field ) {
            $field = '_main';
              Severity: Minor
              Found in src/components/form-upload-manager.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status