Sign upLogin

awsmug/torro-forms

View on GitHub
Star
src/db-objects/forms/form.php

Summary

Maintainability
C
1 day
Test Coverage

File form.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Form class
 *
 * @package TorroForms
Severity: Minor
Found in src/db-objects/forms/form.php - About 2 hrs to fix

    Method __set has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __set( $property, $value ) {
        $found   = false;
        $changed = false;

        switch ( $property ) {
    Severity: Minor
    Found in src/db-objects/forms/form.php - About 1 hr to fix

      Function __set has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __set( $property, $value ) {
        $found   = false;
        $changed = false;

        switch ( $property ) {
      Severity: Minor
      Found in src/db-objects/forms/form.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method duplicate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function duplicate( $as_draft = true, $new_title = '' ) {
        if ( empty( $this->original->ID ) ) {
            return new WP_Error( 'form_post_not_exist', __( 'The form post does not exist in the database.', 'torro-forms' ) );
        }
      Severity: Minor
      Found in src/db-objects/forms/form.php - About 1 hr to fix

        Method duplicate_comments_for_form has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function duplicate_comments_for_form( $form_id ) {
        if ( ! post_type_supports( $this->manager->get_prefix() . 'form', 'comments' ) ) {
            return;
        }
        Severity: Minor
        Found in src/db-objects/forms/form.php - About 1 hr to fix

          Function duplicate_comments_for_form has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function duplicate_comments_for_form( $form_id ) {
        if ( ! post_type_supports( $this->manager->get_prefix() . 'form', 'comments' ) ) {
            return;
        }
          Severity: Minor
          Found in src/db-objects/forms/form.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function duplicate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function duplicate( $as_draft = true, $new_title = '' ) {
        if ( empty( $this->original->ID ) ) {
            return new WP_Error( 'form_post_not_exist', __( 'The form post does not exist in the database.', 'torro-forms' ) );
        }
          Severity: Minor
          Found in src/db-objects/forms/form.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return parent::__get( $property );
          Severity: Major
          Found in src/db-objects/forms/form.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return (int) strtotime( $this->original->post_modified_gmt );
            Severity: Major
            Found in src/db-objects/forms/form.php - About 30 mins to fix

              Function duplicate_metadata_for_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function duplicate_metadata_for_form( $form_id ) {
        $forbidden_meta = array( '_edit_lock', '_edit_last' );

        $meta = get_post_meta( $this->original->ID );
        foreach ( $meta as $meta_key => $meta_values ) {
              Severity: Minor
              Found in src/db-objects/forms/form.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function get_containers( $args = array() ) {
        if ( empty( $this->original->ID ) ) {
            return $this->manager->get_child_manager( 'containers' )->get_collection( array(), 0, 'objects' );
        }
              Severity: Minor
              Found in src/db-objects/forms/form.php and 1 other location - About 50 mins to fix
              src/db-objects/forms/form.php on lines 221..235

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function get_submissions( $args = array() ) {
        if ( empty( $this->original->ID ) ) {
            return $this->manager->get_child_manager( 'submissions' )->get_collection( array(), 0, 'objects' );
        }
              Severity: Minor
              Found in src/db-objects/forms/form.php and 1 other location - About 50 mins to fix
              src/db-objects/forms/form.php on lines 173..187

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status