Sign upLogin

awsmug/torro-forms

View on GitHub
Star
src/db-objects/submissions/submission-manager.php

Summary

Maintainability
D
1 day
Test Coverage

Function maybe_clean_count_cache has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function maybe_clean_count_cache( $new_db_object, $old_db_object ) {
        $delete_user_count = false;
        $delete_form_count = false;

        if ( null === $new_db_object || null === $old_db_object || $new_db_object->status !== $old_db_object->status ) {
Severity: Minor
Found in src/db-objects/submissions/submission-manager.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File submission-manager.php has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Submission manager class
 *
 * @package TorroForms
Severity: Minor
Found in src/db-objects/submissions/submission-manager.php - About 3 hrs to fix

    Method maybe_clean_count_cache has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function maybe_clean_count_cache( $new_db_object, $old_db_object ) {
        $delete_user_count = false;
        $delete_form_count = false;

        if ( null === $new_db_object || null === $old_db_object || $new_db_object->status !== $old_db_object->status ) {
    Severity: Minor
    Found in src/db-objects/submissions/submission-manager.php - About 1 hr to fix

      Method count has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function count( $user_id = 0, $form_id = 0 ) {
        $user_id = absint( $user_id );
        $form_id = absint( $form_id );

        $cache_key = $this->plural_slug;
      Severity: Minor
      Found in src/db-objects/submissions/submission-manager.php - About 1 hr to fix

        Function get_element_values_data_for_submission has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_element_values_data_for_submission( $submission, $force = false ) {
        if ( ! isset( $this->element_values[ $submission->id ] ) || $force ) {
            $this->element_values[ $submission->id ] = array();

            foreach ( $submission->get_submission_values() as $submission_value ) {
        Severity: Minor
        Found in src/db-objects/submissions/submission-manager.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setup_hooks has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function setup_hooks() {
        parent::setup_hooks();

        $this->actions[] = array(
            'name'     => 'admin_init',
        Severity: Minor
        Found in src/db-objects/submissions/submission-manager.php - About 1 hr to fix

          Function count has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function count( $user_id = 0, $form_id = 0 ) {
        $user_id = absint( $user_id );
        $form_id = absint( $form_id );

        $cache_key = $this->plural_slug;
          Severity: Minor
          Found in src/db-objects/submissions/submission-manager.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function set_initial_submission_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function set_initial_submission_data( $submission, $form ) {
        $submission->form_id   = $form->id;
        $submission->status    = 'progressing';
        $submission->timestamp = current_time( 'timestamp', true );
          Severity: Minor
          Found in src/db-objects/submissions/submission-manager.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( $delete_form_count ) {
            if ( null !== $new_db_object ) {
                $form_ids[] = absint( $new_db_object->form_id );
            }
            if ( null !== $old_db_object && ! in_array( absint( $old_db_object->form_id ), $form_ids, true ) ) {
          Severity: Minor
          Found in src/db-objects/submissions/submission-manager.php and 1 other location - About 45 mins to fix
          src/db-objects/submissions/submission-manager.php on lines 274..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( $delete_user_count ) {
            if ( null !== $new_db_object ) {
                $user_ids[] = absint( $new_db_object->user_id );
            }
            if ( null !== $old_db_object && ! in_array( absint( $old_db_object->user_id ), $user_ids, true ) ) {
          Severity: Minor
          Found in src/db-objects/submissions/submission-manager.php and 1 other location - About 45 mins to fix
          src/db-objects/submissions/submission-manager.php on lines 284..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status