Sign upLogin

awsmug/torro-forms

View on GitHub
Star
src/modules/access-controls/members.php

Summary

Maintainability
F
3 days
Test Coverage

File members.php has 446 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Members access control class
 *
 * @package TorroForms
Severity: Minor
Found in src/modules/access-controls/members.php - About 6 hrs to fix

    Method register_template_tag_handlers has 127 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function register_template_tag_handlers() {
        $tags = array(
            'sitetitle'       => array(
                'group'       => 'global',
                'label'       => __( 'Site Title', 'torro-forms' ),
    Severity: Major
    Found in src/modules/access-controls/members.php - About 5 hrs to fix

      Method get_settings_fields has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_settings_fields() {
        $settings_fields = parent::get_settings_fields();

        $domain = wp_parse_url( home_url( '/' ), PHP_URL_HOST );
        if ( ! $domain ) {
      Severity: Major
      Found in src/modules/access-controls/members.php - About 3 hrs to fix

        Method ajax_invite_member has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function ajax_invite_member( $data ) {
        if ( empty( $data['userId'] ) || empty( $data['formId'] ) ) {
            return new WP_Error( 'missing_parameters', __( 'Missing request parameters.', 'torro-forms' ) );
        }
        Severity: Minor
        Found in src/modules/access-controls/members.php - About 1 hr to fix

          Method get_meta_fields has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_meta_fields() {
        $meta_fields = parent::get_meta_fields();

        $role_choices = array();
        foreach ( wp_roles()->roles as $role => $details ) {
          Severity: Minor
          Found in src/modules/access-controls/members.php - About 1 hr to fix

            Function can_access has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function can_access( $form, $submission = null ) {
        if ( ! is_user_logged_in() ) {
            $message = $this->get_form_option( $form->id, 'login_required_message' );
            if ( empty( $message ) ) {
                $message = $this->get_default_login_required_message();
            Severity: Minor
            Found in src/modules/access-controls/members.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method can_access has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function can_access( $form, $submission = null ) {
        if ( ! is_user_logged_in() ) {
            $message = $this->get_form_option( $form->id, 'login_required_message' );
            if ( empty( $message ) ) {
                $message = $this->get_default_login_required_message();
            Severity: Minor
            Found in src/modules/access-controls/members.php - About 1 hr to fix

              Function ajax_invite_member has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function ajax_invite_member( $data ) {
        if ( empty( $data['userId'] ) || empty( $data['formId'] ) ) {
            return new WP_Error( 'missing_parameters', __( 'Missing request parameters.', 'torro-forms' ) );
        }
              Severity: Minor
              Found in src/modules/access-controls/members.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                                  return $user->user_email;
              Severity: Major
              Found in src/modules/access-controls/members.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return wp_get_referer();
                Severity: Major
                Found in src/modules/access-controls/members.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new WP_Error( 'cannot_invite_user', sprintf( __( 'User %s could not be invited.', 'torro-forms' ), $user->display_name ) );
                  Severity: Major
                  Found in src/modules/access-controls/members.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return get_permalink( $form->id );
                    Severity: Major
                    Found in src/modules/access-controls/members.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return new WP_Error( 'not_selected', $message );
                      Severity: Major
                      Found in src/modules/access-controls/members.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return array(
                /* translators: %s: user display name */
                'message' => sprintf( __( 'User %s was successfully reinvited.', 'torro-forms' ), $user->display_name ),
            );
                        Severity: Major
                        Found in src/modules/access-controls/members.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                  return '0.0.0.0';
                          Severity: Major
                          Found in src/modules/access-controls/members.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return $validated_ip;
                            Severity: Major
                            Found in src/modules/access-controls/members.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return $user->display_name;
                              Severity: Major
                              Found in src/modules/access-controls/members.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                    return get_edit_post_link( $form->id );
                                Severity: Major
                                Found in src/modules/access-controls/members.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                          return array(
            /* translators: %s: user display name */
            'message' => sprintf( __( 'User %s was successfully invited.', 'torro-forms' ), $user->display_name ),
        );
                                  Severity: Major
                                  Found in src/modules/access-controls/members.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                        return $form->title;
                                    Severity: Major
                                    Found in src/modules/access-controls/members.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                          return $user->user_login;
                                      Severity: Major
                                      Found in src/modules/access-controls/members.php - About 30 mins to fix

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                            protected function get_default_reinvitation_message() {
        /* translators: %s: user display name */
        $message = sprintf( __( 'Dear %s,', 'torro-forms' ), '{userdisplayname}' ) . "\n\n";

        /* translators: %s: form title */
                                        Severity: Major
                                        Found in src/modules/access-controls/members.php and 1 other location - About 1 hr to fix
                                        src/modules/access-controls/members.php on lines 553..564

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 108.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                            protected function get_default_invitation_message() {
        /* translators: %s: user display name */
        $message = sprintf( __( 'Dear %s,', 'torro-forms' ), '{userdisplayname}' ) . "\n\n";

        /* translators: %s: form title */
                                        Severity: Major
                                        Found in src/modules/access-controls/members.php and 1 other location - About 1 hr to fix
                                        src/modules/access-controls/members.php on lines 573..584

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 108.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status