Sign upLogin

axamon/hermes

View on GitHub
Star

Showing 21 of 21 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func KafkaLocalConsumer(ctx context.Context, topic string, oldoffset int64) (data []byte, offset int64, err error) {

    ctx, cancel := context.WithCancel(ctx)
    defer cancel()
Severity: Major
Found in consumalog/kafka.go and 1 other location - About 2 hrs to fix
producilog/kafka.go on lines 19..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func KafkaLocalConsumer(ctx context.Context, topic string, oldoffset int64) (data []byte, offset int64, err error) {

    ctx, cancel := context.WithCancel(ctx)
    defer cancel()
Severity: Major
Found in producilog/kafka.go and 1 other location - About 2 hrs to fix
consumalog/kafka.go on lines 33..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function upload has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func upload(w http.ResponseWriter, r *http.Request) {
    ctx, cancel := context.WithCancel(r.Context())
    defer cancel()

    // In caso di panico recupera senza killare il server.
Severity: Minor
Found in webapp/server/handlers.go - About 1 hr to fix

    Function main has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {

    flag.Parse()

    var start = time.Now()
    Severity: Minor
    Found in main.go - About 1 hr to fix

      Function REGMAN has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func REGMAN(ctx context.Context, logfile string, maxNumRoutines int) (err error) {

    ctx, cancel := context.WithCancel(ctx)
    defer cancel()
      Severity: Minor
      Found in parsers/regman.go - About 1 hr to fix

        Your code does not pass gofmt in 10 places. Go fmt your code!
        Open

        // Copyright 2019 Alberto Bregliano. All rights reserved.
        Severity: Minor
        Found in parsers/cdn.go by gofmt

        Function upload has 5 return statements (exceeds 4 allowed).
        Open

        func upload(w http.ResponseWriter, r *http.Request) {
    ctx, cancel := context.WithCancel(r.Context())
    defer cancel()

    // In caso di panico recupera senza killare il server.
        Severity: Major
        Found in webapp/server/handlers.go - About 35 mins to fix

          Your code does not pass gofmt in 3 places. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in parsers/rawurl.go by gofmt

          Your code does not pass gofmt in 3 places. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in main.go by gofmt

          Your code does not pass gofmt in 3 places. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in parsers/vod.go by gofmt

          Your code does not pass gofmt in 2 places. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in idvideoteca/idvideotecatool/main.go by gofmt

          Your code does not pass gofmt in 2 places. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in idvideoteca/find.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in manifest/find.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package titolovod
          Severity: Minor
          Found in titolovod/titolovod.go by gofmt

          exported type Response should have comment or be unexported
          Open

          type Response []struct {
          Severity: Minor
          Found in titolovod/titolovod.go by golint

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in parsers/common.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in manifest/manifesttool/main.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright (c) 2019 Alberto Bregliano
          Severity: Minor
          Found in webapp/server/main.go by gofmt

          2: cannot find package "github.com/segmentio/kafka-go" in any of:
          Open

              "github.com/segmentio/kafka-go"
          Severity: Minor
          Found in consumalog/kafka.go by govet

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright 2019 Alberto Bregliano. All rights reserved.
          Severity: Minor
          Found in diagnostictoolclient/main.go by gofmt
          Severity
          Category
          Status
          Source
          Language