axsh/wakame-vdc

View on GitHub
dcmgr/lib/dcmgr/drivers/hypervisor/linux_hypervisor/linux_container/openvz.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method run_instance has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run_instance(hc)
        # write a openvz container id
        inst = hc.inst
        ctid_file_path = File.expand_path('openvz.ctid', hc.inst_data_dir)

Method run_instance has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def run_instance(hc)
        # write a openvz container id
        inst = hc.inst
        ctid_file_path = File.expand_path('openvz.ctid', hc.inst_data_dir)

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method terminate_instance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def terminate_instance(hc)
        poweroff_instance(hc)

        # delete container folder
        sh("vzctl destroy %s",[hc.inst_id])

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status